2021-09-28 14:21:50

by Cai,Huoqing

Subject: [PATCH v3 5/9] iio: adc: max1241: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/iio/adc/max1241.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/iio/adc/max1241.c b/drivers/iio/adc/max1241.c
index b60f8448f21a..130ca8dc6fa0 100644
--- a/drivers/iio/adc/max1241.c
+++ b/drivers/iio/adc/max1241.c
@@ -148,10 +148,9 @@ static int max1241_probe(struct spi_device *spi)
mutex_init(&adc->lock);

adc->vdd = devm_regulator_get(dev, "vdd");
- if (IS_ERR(adc->vdd)) {
- dev_err(dev, "failed to get vdd regulator\n");
- return PTR_ERR(adc->vdd);
- }
+ if (IS_ERR(adc->vdd))
+ return dev_err_probe(dev, PTR_ERR(adc->vdd),
+ "failed to get vdd regulator\n");

ret = regulator_enable(adc->vdd);
if (ret)
@@ -164,10 +163,9 @@ static int max1241_probe(struct spi_device *spi)
}

adc->vref = devm_regulator_get(dev, "vref");
- if (IS_ERR(adc->vref)) {
- dev_err(dev, "failed to get vref regulator\n");
- return PTR_ERR(adc->vref);
- }
+ if (IS_ERR(adc->vref))
+ return dev_err_probe(dev, PTR_ERR(adc->vref),
+ "failed to get vref regulator\n");

ret = regulator_enable(adc->vref);
if (ret)
--
2.25.1

2021-09-29 16:38:20

by Jonathan Cameron

Subject: Re: [PATCH v3 5/9] iio: adc: max1241: Make use of the helper function dev_err_probe()

On Tue, 28 Sep 2021 22:19:51 +0800
Cai Huoqing <[email protected]> wrote:

> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
>
> Signed-off-by: Cai Huoqing <[email protected]>
Hi Cai,

Please also add a message to the
devm_gpiod_get_optional() and similar handling so that we
maintain information on that as well.

Thanks,

Jonathan

> ---
> drivers/iio/adc/max1241.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/iio/adc/max1241.c b/drivers/iio/adc/max1241.c
> index b60f8448f21a..130ca8dc6fa0 100644
> --- a/drivers/iio/adc/max1241.c
> +++ b/drivers/iio/adc/max1241.c
> @@ -148,10 +148,9 @@ static int max1241_probe(struct spi_device *spi)
> mutex_init(&adc->lock);
>
> adc->vdd = devm_regulator_get(dev, "vdd");
> - if (IS_ERR(adc->vdd)) {
> - dev_err(dev, "failed to get vdd regulator\n");
> - return PTR_ERR(adc->vdd);
> - }
> + if (IS_ERR(adc->vdd))
> + return dev_err_probe(dev, PTR_ERR(adc->vdd),
> + "failed to get vdd regulator\n");
>
> ret = regulator_enable(adc->vdd);
> if (ret)
> @@ -164,10 +163,9 @@ static int max1241_probe(struct spi_device *spi)
> }
>
> adc->vref = devm_regulator_get(dev, "vref");
> - if (IS_ERR(adc->vref)) {
> - dev_err(dev, "failed to get vref regulator\n");
> - return PTR_ERR(adc->vref);
> - }
> + if (IS_ERR(adc->vref))
> + return dev_err_probe(dev, PTR_ERR(adc->vref),
> + "failed to get vref regulator\n");
>
> ret = regulator_enable(adc->vref);
> if (ret)