2021-09-28 16:42:40

by Mianhan Liu

Subject: [PATCH -next] net/ipv4/fib_notifier.c remove superfluous header files from fib_notifier.c

fib_notifier.chasn't use any macro or function declared in net/netns/ipv4.h.
Thus, these files can be removed from fib_notifier.c safely without
affecting the compilation of the net/ipv4 module.

Signed-off-by: Mianhan Liu <[email protected]>

---
net/ipv4/fib_notifier.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/ipv4/fib_notifier.c b/net/ipv4/fib_notifier.c
index 0c28bd469..0e23ade74 100644
--- a/net/ipv4/fib_notifier.c
+++ b/net/ipv4/fib_notifier.c
@@ -6,7 +6,6 @@
#include <linux/export.h>
#include <net/net_namespace.h>
#include <net/fib_notifier.h>
-#include <net/netns/ipv4.h>
#include <net/ip_fib.h>

int call_fib4_notifier(struct notifier_block *nb,
--
2.25.1

2021-09-29 00:36:05

by Jakub Kicinski

Subject: Re: [PATCH -next] net/ipv4/fib_notifier.c remove superfluous header files from fib_notifier.c

On Wed, 29 Sep 2021 00:40:11 +0800 Mianhan Liu wrote:
> fib_notifier.chasn't use any macro or function declared in net/netns/ipv4.h.
> Thus, these files can be removed from fib_notifier.c safely without
> affecting the compilation of the net/ipv4 module.
>
> Signed-off-by: Mianhan Liu <[email protected]>

This one looks fine, applied, thanks!