2021-09-28 22:58:25

by Enzo Matsumiya

Subject: [PATCH] ksmbd: fix documentation for 2 functions

ksmbd_kthread_fn() and create_socket() returns 0 or error code, and not
task_struct/ERR_PTR.

Signed-off-by: Enzo Matsumiya <[email protected]>
---
fs/ksmbd/transport_tcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ksmbd/transport_tcp.c b/fs/ksmbd/transport_tcp.c
index dc15a5ecd2e0..c14320e03b69 100644
--- a/fs/ksmbd/transport_tcp.c
+++ b/fs/ksmbd/transport_tcp.c
@@ -215,7 +215,7 @@ static int ksmbd_tcp_new_connection(struct socket *client_sk)
* ksmbd_kthread_fn() - listen to new SMB connections and callback server
* @p: arguments to forker thread
*
- * Return: Returns a task_struct or ERR_PTR
+ * Return: 0 on success, error number otherwise
*/
static int ksmbd_kthread_fn(void *p)
{
@@ -387,7 +387,7 @@ static void tcp_destroy_socket(struct socket *ksmbd_socket)
/**
* create_socket - create socket for ksmbd/0
*
- * Return: Returns a task_struct or ERR_PTR
+ * Return: 0 on success, error number otherwise
*/
static int create_socket(struct interface *iface)
{
--
2.33.0

2021-09-29 00:10:43

by Namjae Jeon

Subject: Re: [PATCH] ksmbd: fix documentation for 2 functions

2021-09-29 7:56 GMT+09:00, Enzo Matsumiya <[email protected]>:
> ksmbd_kthread_fn() and create_socket() returns 0 or error code, and not
> task_struct/ERR_PTR.
>
> Signed-off-by: Enzo Matsumiya <[email protected]>
Acked-by: Namjae Jeon <[email protected]>

Thanks for your patch!

2021-09-29 04:32:01

by Steve French

Subject: Re: [PATCH] ksmbd: fix documentation for 2 functions

merged into cifsd-for-next

On Tue, Sep 28, 2021 at 7:10 PM Namjae Jeon <[email protected]> wrote:
>
> 2021-09-29 7:56 GMT+09:00, Enzo Matsumiya <[email protected]>:
> > ksmbd_kthread_fn() and create_socket() returns 0 or error code, and not
> > task_struct/ERR_PTR.
> >
> > Signed-off-by: Enzo Matsumiya <[email protected]>
> Acked-by: Namjae Jeon <[email protected]>
>
> Thanks for your patch!



--
Thanks,

Steve