2021-09-29 07:04:20

by Mianhan Liu

[permalink] [raw]
Subject: [PATCH -next] clk/actions/owl-factor.c: remove superfluous headers

owl-factor.c hasn't use any macro or function declared in linux/slab.h.
Thus, these files can be removed from owl-factor.c safely without
affecting the compilation of the ./drivers/clk module

Signed-off-by: Mianhan Liu <[email protected]>

---
drivers/clk/actions/owl-factor.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/clk/actions/owl-factor.c b/drivers/clk/actions/owl-factor.c
index f15e2621f..64f316cf7 100644
--- a/drivers/clk/actions/owl-factor.c
+++ b/drivers/clk/actions/owl-factor.c
@@ -10,7 +10,6 @@

#include <linux/clk-provider.h>
#include <linux/regmap.h>
-#include <linux/slab.h>

#include "owl-factor.h"

--
2.25.1



2021-10-01 07:16:43

by Manivannan Sadhasivam

[permalink] [raw]
Subject: Re: [PATCH -next] clk/actions/owl-factor.c: remove superfluous headers

On Wed, Sep 29, 2021 at 02:58:24PM +0800, Mianhan Liu wrote:
> owl-factor.c hasn't use any macro or function declared in linux/slab.h.
> Thus, these files can be removed from owl-factor.c safely without
> affecting the compilation of the ./drivers/clk module
>
> Signed-off-by: Mianhan Liu <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani
>
> ---
> drivers/clk/actions/owl-factor.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/actions/owl-factor.c b/drivers/clk/actions/owl-factor.c
> index f15e2621f..64f316cf7 100644
> --- a/drivers/clk/actions/owl-factor.c
> +++ b/drivers/clk/actions/owl-factor.c
> @@ -10,7 +10,6 @@
>
> #include <linux/clk-provider.h>
> #include <linux/regmap.h>
> -#include <linux/slab.h>
>
> #include "owl-factor.h"
>
> --
> 2.25.1
>
>

2021-11-02 21:29:57

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH -next] clk/actions/owl-factor.c: remove superfluous headers

Quoting Mianhan Liu (2021-09-28 23:58:24)
> owl-factor.c hasn't use any macro or function declared in linux/slab.h.
> Thus, these files can be removed from owl-factor.c safely without
> affecting the compilation of the ./drivers/clk module
>
> Signed-off-by: Mianhan Liu <[email protected]>
>
> ---

Applied to clk-next