2021-09-29 13:31:05

by Colin King

Subject: [PATCH][next] octeontx2-af: Remove redundant initialization of variable pin

From: Colin Ian King <[email protected]>

The variable pin is being initialized with a value that is never
read, it is being updated later on in only one case of a switch
statement. The assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c
index 5e3056a89ee0..bc29ec834967 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c
@@ -194,7 +194,7 @@ static int otx2_ptp_enable(struct ptp_clock_info *ptp_info,
{
struct otx2_ptp *ptp = container_of(ptp_info, struct otx2_ptp,
ptp_info);
- int pin = -1;
+ int pin;

if (!ptp->nic)
return -ENODEV;
--
2.32.0

2021-09-30 12:51:06

by patchwork-bot+netdevbpf

Subject: Re: [PATCH][next] octeontx2-af: Remove redundant initialization of variable pin

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 29 Sep 2021 14:27:53 +0100 you wrote:
> From: Colin Ian King <[email protected]>
>
> The variable pin is being initialized with a value that is never
> read, it is being updated later on in only one case of a switch
> statement. The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
>
> [...]

Here is the summary with links:
- [next] octeontx2-af: Remove redundant initialization of variable pin
https://git.kernel.org/netdev/net-next/c/75f81afb27c3

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html