2021-09-28 14:21:39

by Cai,Huoqing

Subject: [PATCH v3 2/9] iio: adc: imx7d_adc: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/iio/adc/imx7d_adc.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/drivers/iio/adc/imx7d_adc.c b/drivers/iio/adc/imx7d_adc.c
index 4969a5f941e3..f47360cbff3b 100644
--- a/drivers/iio/adc/imx7d_adc.c
+++ b/drivers/iio/adc/imx7d_adc.c
@@ -496,19 +496,13 @@ static int imx7d_adc_probe(struct platform_device *pdev)
return irq;

info->clk = devm_clk_get(dev, "adc");
- if (IS_ERR(info->clk)) {
- ret = PTR_ERR(info->clk);
- dev_err(dev, "Failed getting clock, err = %d\n", ret);
- return ret;
- }
+ if (IS_ERR(info->clk))
+ return dev_err_probe(dev, PTR_ERR(info->clk), "Failed getting clock\n");

info->vref = devm_regulator_get(dev, "vref");
- if (IS_ERR(info->vref)) {
- ret = PTR_ERR(info->vref);
- dev_err(dev,
- "Failed getting reference voltage, err = %d\n", ret);
- return ret;
- }
+ if (IS_ERR(info->vref))
+ return dev_err_probe(dev, PTR_ERR(info->vref),
+ "Failed getting reference voltage\n");

platform_set_drvdata(pdev, indio_dev);

--
2.25.1

2021-09-29 16:26:41

by Jonathan Cameron

Subject: Re: [PATCH v3 2/9] iio: adc: imx7d_adc: Make use of the helper function dev_err_probe()

On Tue, 28 Sep 2021 22:19:48 +0800
Cai Huoqing <[email protected]> wrote:

> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
>
> Signed-off-by: Cai Huoqing <[email protected]>
Hi Cai,

It is currently not printing a message, but should we handle the same
for platform_get_irq?

One other minor comment inline. Actual change here is fine.

Thanks,

Jonathan

> ---
> drivers/iio/adc/imx7d_adc.c | 16 +++++-----------
> 1 file changed, 5 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/iio/adc/imx7d_adc.c b/drivers/iio/adc/imx7d_adc.c
> index 4969a5f941e3..f47360cbff3b 100644
> --- a/drivers/iio/adc/imx7d_adc.c
> +++ b/drivers/iio/adc/imx7d_adc.c
> @@ -496,19 +496,13 @@ static int imx7d_adc_probe(struct platform_device *pdev)
> return irq;
>
> info->clk = devm_clk_get(dev, "adc");
> - if (IS_ERR(info->clk)) {
> - ret = PTR_ERR(info->clk);
> - dev_err(dev, "Failed getting clock, err = %d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(info->clk))
> + return dev_err_probe(dev, PTR_ERR(info->clk), "Failed getting clock\n");

Where it doesn't hurt readabilty preferred to keep below 80 chars.

>
> info->vref = devm_regulator_get(dev, "vref");
> - if (IS_ERR(info->vref)) {
> - ret = PTR_ERR(info->vref);
> - dev_err(dev,
> - "Failed getting reference voltage, err = %d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(info->vref))
> + return dev_err_probe(dev, PTR_ERR(info->vref),
> + "Failed getting reference voltage\n");
>
> platform_set_drvdata(pdev, indio_dev);
>