2021-09-29 21:31:58

by Florian Weimer

Subject: [PATCH] procfs: Do not list TID 0 in /proc/<pid>/task

If a task exits concurrently, task_pid_nr_ns may return 0.

Signed-off-by: Florian Weimer <[email protected]>
---
fs/proc/base.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/fs/proc/base.c b/fs/proc/base.c
index 533d5836eb9a..54f29399088f 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -3800,6 +3800,9 @@ static int proc_task_readdir(struct file *file, struct dir_context *ctx)
char name[10 + 1];
unsigned int len;
tid = task_pid_nr_ns(task, ns);
+ if (!tid)
+ /* The task has just exited. */
+ continue;
len = snprintf(name, sizeof(name), "%u", tid);
if (!proc_fill_cache(file, ctx, name, len,
proc_task_instantiate, task, NULL)) {
--
2.31.1

2021-09-30 13:00:08

by Christian Brauner

Subject: Re: [PATCH] procfs: Do not list TID 0 in /proc/<pid>/task

On Wed, Sep 29, 2021 at 10:23:32PM +0200, Florian Weimer wrote:
> If a task exits concurrently, task_pid_nr_ns may return 0.
>
> Signed-off-by: Florian Weimer <[email protected]>
> ---

Looks good,
Acked-by: Christian Brauner <[email protected]>