2021-10-01 17:41:24

by Andy Shevchenko

[permalink] [raw]
Subject: [PATCH v1 1/1] mtd: spi-nor: intel-spi: Add support for Intel Ice Lake-N SPI serial flash

Intel Ice Lake-N has the same SPI serial flash controller as Ice Lake-LP.
Add Ice Lake-N PCI ID to the driver list of supported devices.

The device can be found on MacBookPro16,2 [1].

[1]: https://linux-hardware.org/?probe=f1c5cf0c43

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/mtd/spi-nor/controllers/intel-spi-pci.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/spi-nor/controllers/intel-spi-pci.c b/drivers/mtd/spi-nor/controllers/intel-spi-pci.c
index 1bc53b8bb88a..f9bcd2dabb4f 100644
--- a/drivers/mtd/spi-nor/controllers/intel-spi-pci.c
+++ b/drivers/mtd/spi-nor/controllers/intel-spi-pci.c
@@ -70,6 +70,7 @@ static const struct pci_device_id intel_spi_pci_ids[] = {
{ PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
{ PCI_VDEVICE(INTEL, 0x1bca), (unsigned long)&bxt_info },
{ PCI_VDEVICE(INTEL, 0x34a4), (unsigned long)&bxt_info },
+ { PCI_VDEVICE(INTEL, 0x38a4), (unsigned long)&bxt_info },
{ PCI_VDEVICE(INTEL, 0x43a4), (unsigned long)&cnl_info },
{ PCI_VDEVICE(INTEL, 0x4b24), (unsigned long)&bxt_info },
{ PCI_VDEVICE(INTEL, 0x4da4), (unsigned long)&bxt_info },
--
2.33.0


2021-10-01 19:58:09

by Michael Walle

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] mtd: spi-nor: intel-spi: Add support for Intel Ice Lake-N SPI serial flash

Am 1. Oktober 2021 19:15:30 MESZ schrieb Andy Shevchenko <[email protected]>:
>Intel Ice Lake-N has the same SPI serial flash controller as Ice Lake-LP.
>Add Ice Lake-N PCI ID to the driver list of supported devices.
>
>The device can be found on MacBookPro16,2 [1].
>
>[1]: https://linux-hardware.org/?probe=f1c5cf0c43
>
>Signed-off-by: Andy Shevchenko <[email protected]>

Hi Andy,

there is currently a rewrite of this driver (to use spi-mem)
in progress:

https://lore.kernel.org/linux-mtd/[email protected]/

Could you try that series with your hardware?

-michael

2021-10-01 20:08:20

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] mtd: spi-nor: intel-spi: Add support for Intel Ice Lake-N SPI serial flash

On Fri, Oct 01, 2021 at 07:21:08PM +0200, Michael Walle wrote:
> Am 1. Oktober 2021 19:15:30 MESZ schrieb Andy Shevchenko <[email protected]>:
> >Intel Ice Lake-N has the same SPI serial flash controller as Ice Lake-LP.
> >Add Ice Lake-N PCI ID to the driver list of supported devices.
> >
> >The device can be found on MacBookPro16,2 [1].
> >
> >[1]: https://linux-hardware.org/?probe=f1c5cf0c43
> >
> >Signed-off-by: Andy Shevchenko <[email protected]>
>
> Hi Andy,
>
> there is currently a rewrite of this driver (to use spi-mem)
> in progress:
>
> https://lore.kernel.org/linux-mtd/[email protected]/
>
> Could you try that series with your hardware?

It's not mine - can't test myself. I'm helping to enable Linux on it.
But okay, I postpone this till the reworked version will be applied.

--
With Best Regards,
Andy Shevchenko