2021-10-03 08:11:51

by Harris Song

Subject: [PATCH] btrfs: zoned: Use kmemdup() to replace kmalloc + memcpy

fix memdup.cocci warning:
fs/btrfs/zoned.c:1198:23-30: WARNING opportunity for kmemdup

Signed-off-by: Kai Song <[email protected]>
---
fs/btrfs/zoned.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index 1433ee220c94..cfa25f5ede0d 100644
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -1195,14 +1195,12 @@ int btrfs_load_block_group_zone_info(struct btrfs_block_group *cache, bool new)

map = em->map_lookup;

- cache->physical_map = kmalloc(map_lookup_size(map->num_stripes), GFP_NOFS);
+ cache->physical_map = kmemdup(map, map_lookup_size(map->num_stripes), GFP_NOFS);
if (!cache->physical_map) {
ret = -ENOMEM;
goto out;
}

- memcpy(cache->physical_map, map, map_lookup_size(map->num_stripes));
-
alloc_offsets = kcalloc(map->num_stripes, sizeof(*alloc_offsets), GFP_NOFS);
if (!alloc_offsets) {
ret = -ENOMEM;
--
2.27.0

2021-10-04 08:41:10

by Johannes Thumshirn

Subject: Re: [PATCH] btrfs: zoned: Use kmemdup() to replace kmalloc + memcpy

Looks good,
Reviewed-by: Johannes Thumshirn <[email protected]>

2021-10-06 12:20:02

by David Sterba

Subject: Re: [PATCH] btrfs: zoned: Use kmemdup() to replace kmalloc + memcpy

On Sun, Oct 03, 2021 at 04:06:56PM +0800, Kai Song wrote:
> fix memdup.cocci warning:
> fs/btrfs/zoned.c:1198:23-30: WARNING opportunity for kmemdup
>
> Signed-off-by: Kai Song <[email protected]>

Added to misc-next, thanks.