2021-10-04 19:14:33

by Nick Desaulniers

[permalink] [raw]
Subject: Re: [PATCH v6] kallsyms: strip LTO suffixes from static functions

On Mon, Oct 4, 2021 at 11:38 AM Konstantin Ryabitsev
<[email protected]> wrote:
>
> On Mon, Oct 04, 2021 at 11:32:43AM -0700, Nick Desaulniers wrote:
> > $ git format-patch HEAD~
> > 0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch
> > $ git send-email --suppress-cc=body --to [email protected]
> > 0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch
> > patatt: E: -: Not a valid RFC2822 message
> > fatal: 0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch:
> > rejected by sendemail-validate hook
> > fatal: command 'git hook run sendemail-validate -- <patch>' died with
> > exit code 1
> > warning: no patches were sent
>
> Woah. What git version is this?

$ git --version
git version 2.33.0.800.g4c38ced690-goog

Looks like some corporate version...anything else I can to do to help
debug? (Moving explicit CC's to BCC).
--
Thanks,
~Nick Desaulniers


2021-10-04 23:31:11

by Konstantin Ryabitsev

[permalink] [raw]
Subject: Re: [PATCH v6] kallsyms: strip LTO suffixes from static functions

On Mon, Oct 04, 2021 at 11:41:29AM -0700, Nick Desaulniers wrote:
> On Mon, Oct 4, 2021 at 11:38 AM Konstantin Ryabitsev
> <[email protected]> wrote:
> >
> > On Mon, Oct 04, 2021 at 11:32:43AM -0700, Nick Desaulniers wrote:
> > > $ git format-patch HEAD~
> > > 0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch
> > > $ git send-email --suppress-cc=body --to [email protected]
> > > 0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch
> > > patatt: E: -: Not a valid RFC2822 message
> > > fatal: 0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch:
> > > rejected by sendemail-validate hook
> > > fatal: command 'git hook run sendemail-validate -- <patch>' died with
> > > exit code 1
> > > warning: no patches were sent
> >
> > Woah. What git version is this?
>
> $ git --version
> git version 2.33.0.800.g4c38ced690-goog
>
> Looks like some corporate version...anything else I can to do to help
> debug? (Moving explicit CC's to BCC).

Yeah, can you please send me
0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch as an attachment?
Also, the output of running "locale" -- it's got to be something to do with
passing stdin as opposed ot loading from file.

-K

2021-10-04 23:33:34

by Nick Desaulniers

[permalink] [raw]
Subject: Re: [PATCH v6] kallsyms: strip LTO suffixes from static functions

On Mon, Oct 4, 2021 at 11:47 AM Konstantin Ryabitsev
<[email protected]> wrote:
>
> On Mon, Oct 04, 2021 at 11:41:29AM -0700, Nick Desaulniers wrote:
> > On Mon, Oct 4, 2021 at 11:38 AM Konstantin Ryabitsev
> > <[email protected]> wrote:
> > >
> > > On Mon, Oct 04, 2021 at 11:32:43AM -0700, Nick Desaulniers wrote:
> > > > $ git format-patch HEAD~
> > > > 0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch
> > > > $ git send-email --suppress-cc=body --to [email protected]
> > > > 0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch
> > > > patatt: E: -: Not a valid RFC2822 message
> > > > fatal: 0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch:
> > > > rejected by sendemail-validate hook
> > > > fatal: command 'git hook run sendemail-validate -- <patch>' died with
> > > > exit code 1
> > > > warning: no patches were sent
> > >
> > > Woah. What git version is this?
> >
> > $ git --version
> > git version 2.33.0.800.g4c38ced690-goog
> >
> > Looks like some corporate version...anything else I can to do to help
> > debug? (Moving explicit CC's to BCC).
>
> Yeah, can you please send me
> 0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch as an attachment?

Sure, attached via gmail web client.

> Also, the output of running "locale" -- it's got to be something to do with
> passing stdin as opposed ot loading from file.

$ locale
LANG=en_US.UTF-8
LANGUAGE=
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_PAPER="en_US.UTF-8"
LC_NAME="en_US.UTF-8"
LC_ADDRESS="en_US.UTF-8"
LC_TELEPHONE="en_US.UTF-8"
LC_MEASUREMENT="en_US.UTF-8"
LC_IDENTIFICATION="en_US.UTF-8"
LC_ALL=


As a heads up, I sent a PR, too: https://github.com/mricon/patatt/pull/1.

--
Thanks,
~Nick Desaulniers


Attachments:
0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch (1.56 kB)

2021-10-05 00:22:23

by Konstantin Ryabitsev

[permalink] [raw]
Subject: Re: [PATCH v6] kallsyms: strip LTO suffixes from static functions

On Mon, Oct 04, 2021 at 11:41:29AM -0700, Nick Desaulniers wrote:
> On Mon, Oct 4, 2021 at 11:38 AM Konstantin Ryabitsev
> <[email protected]> wrote:
> >
> > On Mon, Oct 04, 2021 at 11:32:43AM -0700, Nick Desaulniers wrote:
> > > $ git format-patch HEAD~
> > > 0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch
> > > $ git send-email --suppress-cc=body --to [email protected]
> > > 0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch
> > > patatt: E: -: Not a valid RFC2822 message
> > > fatal: 0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch:
> > > rejected by sendemail-validate hook
> > > fatal: command 'git hook run sendemail-validate -- <patch>' died with
> > > exit code 1
> > > warning: no patches were sent
> >
> > Woah. What git version is this?
>
> $ git --version
> git version 2.33.0.800.g4c38ced690-goog
>
> Looks like some corporate version...anything else I can to do to help
> debug? (Moving explicit CC's to BCC).

So, this line:

> fatal: command 'git hook run sendemail-validate -- <patch>' died with exit code 1

Suggests to me that your git version is patched to carry the
new-and-not-yet-accepted "git hook" changes. It seems that it both opens a
stdin and passes the file as the parameter. When we find a stdin, we always
grab that instead of the passed parameter, but that's only a problem with this
change to git.

I'll add a fix that will always disregard stdin when we're running with
--hook.

-K