2021-10-05 07:06:38

by Harris Song

[permalink] [raw]
Subject: [PATCH] memory: tegra210-emc: replace DEFINE_SIMPLE_ATTRIBUTE with

fix debugfs_simple_attr.cocci warning:
drivers/memory/tegra/tegra210-emc-core.c:1665:0-23: WARNING:tegra210_emc_debug_min_rate_fops
should be defined with DEFINE_DEBUGFS_ATTRIBUTE

Fixes: 6fc5f1adf5a1 ("memory: tegra210-emc: replace DEFINE_SIMPLE_ATTRIBUTE
with DEFINE_DEBUGFS_ATTRIBUTE"):It reports the same warning, but didn't
fix all matches in this file at once.

Signed-off-by: Kai Song <[email protected]>
---
drivers/memory/tegra/tegra210-emc-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/memory/tegra/tegra210-emc-core.c b/drivers/memory/tegra/tegra210-emc-core.c
index 3b8284c6678e..13584f9317a4 100644
--- a/drivers/memory/tegra/tegra210-emc-core.c
+++ b/drivers/memory/tegra/tegra210-emc-core.c
@@ -1662,7 +1662,7 @@ static int tegra210_emc_debug_min_rate_set(void *data, u64 rate)
return 0;
}

-DEFINE_SIMPLE_ATTRIBUTE(tegra210_emc_debug_min_rate_fops,
+DEFINE_DEBUGFS_ATTRIBUTE(tegra210_emc_debug_min_rate_fops,
tegra210_emc_debug_min_rate_get,
tegra210_emc_debug_min_rate_set, "%llu\n");

--
2.27.0


2021-10-07 17:55:52

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] memory: tegra210-emc: replace DEFINE_SIMPLE_ATTRIBUTE with

On Tue, Oct 05, 2021 at 12:35:14PM +0800, Kai Song wrote:
> fix debugfs_simple_attr.cocci warning:
> drivers/memory/tegra/tegra210-emc-core.c:1665:0-23: WARNING:tegra210_emc_debug_min_rate_fops
> should be defined with DEFINE_DEBUGFS_ATTRIBUTE
>
> Fixes: 6fc5f1adf5a1 ("memory: tegra210-emc: replace DEFINE_SIMPLE_ATTRIBUTE
> with DEFINE_DEBUGFS_ATTRIBUTE"):It reports the same warning, but didn't
> fix all matches in this file at once.
>
> Signed-off-by: Kai Song <[email protected]>
> ---
> drivers/memory/tegra/tegra210-emc-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Thierry Reding <[email protected]>

Attachments:
(No filename) (662.00 B)
 signature.asc (849.00 B)
 Download all attachments

2021-10-07 19:50:42

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] memory: tegra210-emc: replace DEFINE_SIMPLE_ATTRIBUTE with

On Tue, 5 Oct 2021 12:35:14 +0800, Kai Song wrote:
> fix debugfs_simple_attr.cocci warning:
> drivers/memory/tegra/tegra210-emc-core.c:1665:0-23: WARNING:tegra210_emc_debug_min_rate_fops
> should be defined with DEFINE_DEBUGFS_ATTRIBUTE
>
> Fixes: 6fc5f1adf5a1 ("memory: tegra210-emc: replace DEFINE_SIMPLE_ATTRIBUTE
> with DEFINE_DEBUGFS_ATTRIBUTE"):It reports the same warning, but didn't
> fix all matches in this file at once.
>
> [...]

Applied, thanks!

[1/1] memory: tegra210-emc: replace DEFINE_SIMPLE_ATTRIBUTE with
commit: 31b88d85f0432e1c0738fe0714191e8504f505c3

Best regards,
--
Krzysztof Kozlowski <[email protected]>