2021-09-24 14:05:28

by Ezequiel Garcia

Subject: [PATCH] imx: soc: Select REGMAP_MMIO

The imx-gpcv2 driver needs Regmap MMIO. Select it, and fix:

drivers/soc/imx/gpcv2.c:420:34: error: array type has incomplete element type ‘struct regmap_range’
420 | static const struct regmap_range imx7_yes_ranges[] = {
| ^~~~~~~~~~~~~~~
drivers/soc/imx/gpcv2.c:421:17: error: implicit declaration of function ‘regmap_reg_range’; did you mean ‘remap_pfn_range’? [-Werror=implicit-function-declaration]
421 | regmap_reg_range(GPC_LPCR_A_CORE_BSC,
| ^~~~~~~~~~~~~~~~
| remap_pfn_range

Signed-off-by: Ezequiel Garcia <[email protected]>
---
drivers/soc/imx/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
index 05812f8ae734..a840494e849a 100644
--- a/drivers/soc/imx/Kconfig
+++ b/drivers/soc/imx/Kconfig
@@ -6,6 +6,7 @@ config IMX_GPCV2_PM_DOMAINS
depends on ARCH_MXC || (COMPILE_TEST && OF)
depends on PM
select PM_GENERIC_DOMAINS
+ select REGMAP_MMIO
default y if SOC_IMX7D

config SOC_IMX8M
--
2.31.1

2021-10-05 05:56:03

by Shawn Guo

Subject: Re: [PATCH] imx: soc: Select REGMAP_MMIO

On Fri, Sep 24, 2021 at 11:01:46AM -0300, Ezequiel Garcia wrote:
> The imx-gpcv2 driver needs Regmap MMIO. Select it, and fix:
>
> drivers/soc/imx/gpcv2.c:420:34: error: array type has incomplete element type ‘struct regmap_range’
> 420 | static const struct regmap_range imx7_yes_ranges[] = {
> | ^~~~~~~~~~~~~~~
> drivers/soc/imx/gpcv2.c:421:17: error: implicit declaration of function ‘regmap_reg_range’; did you mean ‘remap_pfn_range’? [-Werror=implicit-function-declaration]
> 421 | regmap_reg_range(GPC_LPCR_A_CORE_BSC,
> | ^~~~~~~~~~~~~~~~
> | remap_pfn_range
>
> Signed-off-by: Ezequiel Garcia <[email protected]>

Applied, thanks!