2021-09-30 16:06:56

by Frieder Schrempf

Subject: Re: [PATCH 2/8] arm64: dts: imx8mm-kontron: Make sure SOC and DRAM supply voltages are correct

On 30.09.21 17:56, Frieder Schrempf wrote:
> From: Frieder Schrempf <[email protected]>
>
> VDD_SOC should be 800 mV in suspend and 850 mV in run mode. VDD_DRAM
> should be 950 mV for DDR clock frequencies of 1.5 GHz.
>
> This information is taken from the datasheet and the uboot-imx code.
>
> Signed-off-by: Frieder Schrempf <[email protected]>

This should also have:

Fixes: 21c4f45b335f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and
baseboards")
Cc: [email protected]

> ---
> arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> index 03b3516abd64..b12fb7ce6686 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> @@ -92,10 +92,12 @@ regulators {
> reg_vdd_soc: BUCK1 {
> regulator-name = "buck1";
> regulator-min-microvolt = <800000>;
> - regulator-max-microvolt = <900000>;
> + regulator-max-microvolt = <850000>;
> regulator-boot-on;
> regulator-always-on;
> regulator-ramp-delay = <3125>;
> + nxp,dvs-run-voltage = <850000>;
> + nxp,dvs-standby-voltage = <800000>;
> };
>
> reg_vdd_arm: BUCK2 {
> @@ -111,7 +113,7 @@ reg_vdd_arm: BUCK2 {
> reg_vdd_dram: BUCK3 {
> regulator-name = "buck3";
> regulator-min-microvolt = <850000>;
> - regulator-max-microvolt = <900000>;
> + regulator-max-microvolt = <950000>;
> regulator-boot-on;
> regulator-always-on;
> };
>

2021-10-05 06:51:25

by Shawn Guo

Subject: Re: [PATCH 2/8] arm64: dts: imx8mm-kontron: Make sure SOC and DRAM supply voltages are correct

On Thu, Sep 30, 2021 at 06:02:01PM +0200, Frieder Schrempf wrote:
> On 30.09.21 17:56, Frieder Schrempf wrote:
> > From: Frieder Schrempf <[email protected]>
> >
> > VDD_SOC should be 800 mV in suspend and 850 mV in run mode. VDD_DRAM
> > should be 950 mV for DDR clock frequencies of 1.5 GHz.
> >
> > This information is taken from the datasheet and the uboot-imx code.
> >
> > Signed-off-by: Frieder Schrempf <[email protected]>
>
> This should also have:
>
> Fixes: 21c4f45b335f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and
> baseboards")

$ git log 21c4f45b335f
fatal: ambiguous argument '21c4f45b335f': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

Shawn

> Cc: [email protected]
>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> > index 03b3516abd64..b12fb7ce6686 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> > @@ -92,10 +92,12 @@ regulators {
> > reg_vdd_soc: BUCK1 {
> > regulator-name = "buck1";
> > regulator-min-microvolt = <800000>;
> > - regulator-max-microvolt = <900000>;
> > + regulator-max-microvolt = <850000>;
> > regulator-boot-on;
> > regulator-always-on;
> > regulator-ramp-delay = <3125>;
> > + nxp,dvs-run-voltage = <850000>;
> > + nxp,dvs-standby-voltage = <800000>;
> > };
> >
> > reg_vdd_arm: BUCK2 {
> > @@ -111,7 +113,7 @@ reg_vdd_arm: BUCK2 {
> > reg_vdd_dram: BUCK3 {
> > regulator-name = "buck3";
> > regulator-min-microvolt = <850000>;
> > - regulator-max-microvolt = <900000>;
> > + regulator-max-microvolt = <950000>;
> > regulator-boot-on;
> > regulator-always-on;
> > };
> >