2021-10-06 11:28:30

by Heikki Krogerus

[permalink] [raw]
Subject: [PATCH v3 0/3] device property: Remove device_add_properties()

Hi,

In this third version of this series, the second patch is now split in
two. The device_remove_properties() call is first removed from
device_del() in its own patch, and the
device_add/remove_properties() API is removed separately in the last
patch. I hope the commit messages are clear enough this time.


v2 cover letter:

This is the second version where I only modified the commit message of
the first patch according to comments from Bjorn.


Original cover letter:

There is one user left for the API, so converting that to use software
node API instead, and removing the function.


Heikki Krogerus (3):
PCI: Convert to device_create_managed_software_node()
driver core: Don't call device_remove_properties() from device_del()
device property: Remove device_add_properties() API

drivers/base/core.c | 1 -
drivers/base/property.c | 48 ----------------------------------------
drivers/pci/quirks.c | 2 +-
include/linux/property.h | 4 ----
4 files changed, 1 insertion(+), 54 deletions(-)

--
2.33.0


2021-10-06 11:29:03

by Heikki Krogerus

[permalink] [raw]
Subject: [PATCH v3 2/3] driver core: Don't call device_remove_properties() from device_del()

All the drivers that relied on device_del() to call
device_remove_properties() have now been converted to either
use device_create_managed_software_node() instead of
device_add_properties(), or to register the software node
completely separately from the device.

This will make it finally possible to share and reuse the
software nodes that hold the additional device properties.

Signed-off-by: Heikki Krogerus <[email protected]>
---
drivers/base/core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index c4a2c97a21a2b..ea39ffad11179 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -3584,7 +3584,6 @@ void device_del(struct device *dev)
device_pm_remove(dev);
driver_deferred_probe_del(dev);
device_platform_notify_remove(dev);
- device_remove_properties(dev);
device_links_purge(dev);

if (dev->bus)
--
2.33.0