2021-08-24 17:20:58

by Manish Narani

Subject: [PATCH 2/6] usb: chipidea: Use usb2 phy for Zynq platform

Add usb2 phy to Zynq platform data.

Signed-off-by: Subbaraya Sundeep Bhatta <[email protected]>
Signed-off-by: Michal Simek <[email protected]>
Signed-off-by: Manish Narani <[email protected]>
---
drivers/usb/chipidea/ci_hdrc_usb2.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c
index dc86b12..be58869 100644
--- a/drivers/usb/chipidea/ci_hdrc_usb2.c
+++ b/drivers/usb/chipidea/ci_hdrc_usb2.c
@@ -65,6 +65,10 @@ static int ci_hdrc_usb2_probe(struct platform_device *pdev)
if (match && match->data) {
/* struct copy */
*ci_pdata = *(struct ci_hdrc_platform_data *)match->data;
+ ci_pdata->usb_phy = devm_usb_get_phy_by_phandle(dev, "usb-phy",
+ 0);
+ if (IS_ERR(ci_pdata->usb_phy))
+ return PTR_ERR(ci_pdata->usb_phy);
}

priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
--
2.1.1

2021-10-07 04:55:29

by Peter Chen

Subject: Re: [PATCH 2/6] usb: chipidea: Use usb2 phy for Zynq platform

On 21-08-24 22:46:14, Manish Narani wrote:
> Add usb2 phy to Zynq platform data.

Please change the subject and comments a little. This file is not only
for xilinx platform, it is for generic chipidea driver. If you would
like this change only for your platform, you may use of_device_id.data
for condition.

Peter

>
> Signed-off-by: Subbaraya Sundeep Bhatta <[email protected]>
> Signed-off-by: Michal Simek <[email protected]>
> Signed-off-by: Manish Narani <[email protected]>
> ---
> drivers/usb/chipidea/ci_hdrc_usb2.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c
> index dc86b12..be58869 100644
> --- a/drivers/usb/chipidea/ci_hdrc_usb2.c
> +++ b/drivers/usb/chipidea/ci_hdrc_usb2.c
> @@ -65,6 +65,10 @@ static int ci_hdrc_usb2_probe(struct platform_device *pdev)
> if (match && match->data) {
> /* struct copy */
> *ci_pdata = *(struct ci_hdrc_platform_data *)match->data;
> + ci_pdata->usb_phy = devm_usb_get_phy_by_phandle(dev, "usb-phy",
> + 0);
> + if (IS_ERR(ci_pdata->usb_phy))
> + return PTR_ERR(ci_pdata->usb_phy);
> }
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> --
> 2.1.1
>

--

Thanks,
Peter Chen