2021-10-07 20:49:38

by Colin King

Subject: [PATCH] RDMA/iwpm: Remove redundant initialization of pointer err_str

From: Colin Ian King <[email protected]>

The pointer err_str is being initialized with a value that is
never read, it is being updated later on. The assignment is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/infiniband/core/iwpm_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/core/iwpm_util.c b/drivers/infiniband/core/iwpm_util.c
index 54f4feb604d8..358a2db38d23 100644
--- a/drivers/infiniband/core/iwpm_util.c
+++ b/drivers/infiniband/core/iwpm_util.c
@@ -762,7 +762,7 @@ int iwpm_send_hello(u8 nl_client, int iwpm_pid, u16 abi_version)
{
struct sk_buff *skb = NULL;
struct nlmsghdr *nlh;
- const char *err_str = "";
+ const char *err_str;
int ret = -EINVAL;

skb = iwpm_create_nlmsg(RDMA_NL_IWPM_HELLO, &nlh, nl_client);
--
2.32.0

2021-10-12 16:20:06

by Jason Gunthorpe

Subject: Re: [PATCH] RDMA/iwpm: Remove redundant initialization of pointer err_str

On Thu, Oct 07, 2021 at 06:39:42PM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The pointer err_str is being initialized with a value that is
> never read, it is being updated later on. The assignment is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/infiniband/core/iwpm_util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

Jason