2021-10-09 19:35:23

by David Heidelberg

Subject: [PATCH 1/2] dt-bindings: arm: qcom-ipq4019: add missing device compatible

One board version (dk01.1-c1) didn't have set device compatible,
so let's list it.

Signed-off-by: David Heidelberg <[email protected]>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index a2e679112737..470984d54720 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -174,6 +174,7 @@ properties:

- items:
- enum:
+ - qcom,ipq4019-ap-dk01.1-c1
- qcom,ipq4019-ap-dk04.1-c3
- qcom,ipq4019-ap-dk07.1-c1
- qcom,ipq4019-ap-dk07.1-c2
--
2.33.0

2021-10-09 19:35:36

by David Heidelberg

Subject: [PATCH 2/2] ARM: dts: ipq4019-ap.dk01.1-c1: add device compatible in the dts

Version dk01.1-c1 didn't have compatible specified, which was
causing dt-schema validation warnings.

Remove duplicated and useless board compatible from dtsi between board and device.

Signed-off-by: David Heidelberg <[email protected]>
---
arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dts | 2 +-
arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dts b/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dts
index 0d92f1bc3a13..ddaa273f72ca 100644
--- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dts
+++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dts
@@ -18,5 +18,5 @@

/ {
model = "Qualcomm Technologies, Inc. IPQ40xx/AP-DK01.1-C1";
-
+ compatible = "qcom,ipq4019-ap-dk01.1-c1", "qcom,ipq4019";
};
diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi b/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi
index c93b2164db44..0c10d9e096db 100644
--- a/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi
@@ -18,7 +18,6 @@

/ {
model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK01.1";
- compatible = "qcom,ipq4019";

aliases {
serial0 = &blsp1_uart1;
--
2.33.0

2021-10-19 22:32:18

by Rob Herring (Arm)

Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom-ipq4019: add missing device compatible

On Sat, 09 Oct 2021 21:31:01 +0200, David Heidelberg wrote:
> One board version (dk01.1-c1) didn't have set device compatible,
> so let's list it.
>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
> 1 file changed, 1 insertion(+)
>

Acked-by: Rob Herring <[email protected]>