2021-10-11 16:41:29

by Vegard Nossum

Subject: [PATCH] staging: ks7010: select CRYPTO_HASH/CRYPTO_MICHAEL_MIC

Fix the following build/link errors:

ld: drivers/staging/ks7010/ks_hostif.o: in function `michael_mic.constprop.0':
ks_hostif.c:(.text+0x95b): undefined reference to `crypto_alloc_shash'
ld: ks_hostif.c:(.text+0x97a): undefined reference to `crypto_shash_setkey'
ld: ks_hostif.c:(.text+0xa13): undefined reference to `crypto_shash_update'
ld: ks_hostif.c:(.text+0xa28): undefined reference to `crypto_shash_update'
ld: ks_hostif.c:(.text+0xa48): undefined reference to `crypto_shash_finup'
ld: ks_hostif.c:(.text+0xa6d): undefined reference to `crypto_destroy_tfm'

Signed-off-by: Vegard Nossum <[email protected]>
---
drivers/staging/ks7010/Kconfig | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/staging/ks7010/Kconfig b/drivers/staging/ks7010/Kconfig
index 0987fdc2f70db..8ea6c09286798 100644
--- a/drivers/staging/ks7010/Kconfig
+++ b/drivers/staging/ks7010/Kconfig
@@ -5,6 +5,9 @@ config KS7010
select WIRELESS_EXT
select WEXT_PRIV
select FW_LOADER
+ select CRYPTO
+ select CRYPTO_HASH
+ select CRYPTO_MICHAEL_MIC
help
This is a driver for KeyStream KS7010 based SDIO WIFI cards. It is
found on at least later Spectec SDW-821 (FCC-ID "S2Y-WLAN-11G-K" only,
--
2.23.0.718.g5ad94255a8

2021-10-13 12:27:47

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: ks7010: select CRYPTO_HASH/CRYPTO_MICHAEL_MIC

On Mon, Oct 11, 2021 at 05:29:41PM +0200, Vegard Nossum wrote:
> Fix the following build/link errors:
>
> ld: drivers/staging/ks7010/ks_hostif.o: in function `michael_mic.constprop.0':
> ks_hostif.c:(.text+0x95b): undefined reference to `crypto_alloc_shash'
> ld: ks_hostif.c:(.text+0x97a): undefined reference to `crypto_shash_setkey'
> ld: ks_hostif.c:(.text+0xa13): undefined reference to `crypto_shash_update'
> ld: ks_hostif.c:(.text+0xa28): undefined reference to `crypto_shash_update'
> ld: ks_hostif.c:(.text+0xa48): undefined reference to `crypto_shash_finup'
> ld: ks_hostif.c:(.text+0xa6d): undefined reference to `crypto_destroy_tfm'
>
> Signed-off-by: Vegard Nossum <[email protected]>
> ---
> drivers/staging/ks7010/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/ks7010/Kconfig b/drivers/staging/ks7010/Kconfig
> index 0987fdc2f70db..8ea6c09286798 100644
> --- a/drivers/staging/ks7010/Kconfig
> +++ b/drivers/staging/ks7010/Kconfig
> @@ -5,6 +5,9 @@ config KS7010
> select WIRELESS_EXT
> select WEXT_PRIV
> select FW_LOADER
> + select CRYPTO
> + select CRYPTO_HASH
> + select CRYPTO_MICHAEL_MIC

Let's try to rely on 'depend' and not 'select' please.

thanks,

greg k-h