2021-10-12 05:27:37

by Christian Hewitt

[permalink] [raw]
Subject: [PATCH 0/3] arm64: dts: meson: fixups for WeTek common dtsi

Two fixes from work on u-boot support and following access to the original
vendor schematics, plus a minor change to use revised LED bindings.

- Mark VDDIO_AO18 always-on and link hdmi-supply to fix HDMI on boot
- Add missing GPIO binding
- Update LED bindings

Christian Hewitt (3):
arm64: dts: meson-gxbb-wetek: fix HDMI in early boot
arm64: dts: meson-gxbb-wetek: fix missing GPIO binding
arm64: dts: meson-gxbb-wetek: use updated LED bindings

arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)

--
2.17.1


2021-10-12 05:27:48

by Christian Hewitt

[permalink] [raw]
Subject: [PATCH 1/3] arm64: dts: meson-gxbb-wetek: fix HDMI in early boot

Mark the VDDIO_AO18 regulator always-on and set hdmi-supply for the hdmi_tx
node to ensure HDMI is powered in the early stages of boot.

Fixes: fb72c03e0e32 ("ARM64: dts: meson-gxbb-wetek: add a wetek specific dtsi to cleanup hub and play2")

Signed-off-by: Christian Hewitt <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
index a350fee1264d..8e2af986ceba 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
@@ -64,6 +64,7 @@
regulator-name = "VDDIO_AO18";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
+ regulator-always-on;
};

vcc_3v3: regulator-vcc_3v3 {
@@ -161,6 +162,7 @@
status = "okay";
pinctrl-0 = <&hdmi_hpd_pins>, <&hdmi_i2c_pins>;
pinctrl-names = "default";
+ hdmi-supply = <&vddio_ao18>;
};

&hdmi_tx_tmds_port {
--
2.17.1

2021-10-12 05:30:12

by Christian Hewitt

[permalink] [raw]
Subject: [PATCH 2/3] arm64: dts: meson-gxbb-wetek: fix missing GPIO binding

The absence of this binding appears to be harmless in Linux but it breaks
Ethernet support in mainline u-boot. So add the binding (which is present
in all other u-boot supported GXBB device-trees).

Fixes: fb72c03e0e32 ("ARM64: dts: meson-gxbb-wetek: add a wetek specific dtsi to cleanup hub and play2")

Signed-off-by: Christian Hewitt <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
index 8e2af986ceba..a4d34398da35 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
@@ -6,6 +6,7 @@
*/

#include "meson-gxbb.dtsi"
+#include <dt-bindings/gpio/gpio.h>

/ {
aliases {
--
2.17.1

2021-11-15 09:26:12

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH 1/3] arm64: dts: meson-gxbb-wetek: fix HDMI in early boot

On 12/10/2021 07:25, Christian Hewitt wrote:
> Mark the VDDIO_AO18 regulator always-on and set hdmi-supply for the hdmi_tx
> node to ensure HDMI is powered in the early stages of boot.
>
> Fixes: fb72c03e0e32 ("ARM64: dts: meson-gxbb-wetek: add a wetek specific dtsi to cleanup hub and play2")
>
> Signed-off-by: Christian Hewitt <[email protected]>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> index a350fee1264d..8e2af986ceba 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> @@ -64,6 +64,7 @@
> regulator-name = "VDDIO_AO18";
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> };
>
> vcc_3v3: regulator-vcc_3v3 {
> @@ -161,6 +162,7 @@
> status = "okay";
> pinctrl-0 = <&hdmi_hpd_pins>, <&hdmi_i2c_pins>;
> pinctrl-names = "default";
> + hdmi-supply = <&vddio_ao18>;
> };
>
> &hdmi_tx_tmds_port {
>

Reviewed-by: Neil Armstrong <[email protected]>

2021-11-15 09:26:40

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH 2/3] arm64: dts: meson-gxbb-wetek: fix missing GPIO binding

On 12/10/2021 07:25, Christian Hewitt wrote:
> The absence of this binding appears to be harmless in Linux but it breaks
> Ethernet support in mainline u-boot. So add the binding (which is present
> in all other u-boot supported GXBB device-trees).
>
> Fixes: fb72c03e0e32 ("ARM64: dts: meson-gxbb-wetek: add a wetek specific dtsi to cleanup hub and play2")
>
> Signed-off-by: Christian Hewitt <[email protected]>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> index 8e2af986ceba..a4d34398da35 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> @@ -6,6 +6,7 @@
> */
>
> #include "meson-gxbb.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>
> / {
> aliases {
>

Reviewed-by: Neil Armstrong <[email protected]>

2021-11-15 09:30:03

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH 0/3] arm64: dts: meson: fixups for WeTek common dtsi

Hi,

On Tue, 12 Oct 2021 05:25:19 +0000, Christian Hewitt wrote:
> Two fixes from work on u-boot support and following access to the original
> vendor schematics, plus a minor change to use revised LED bindings.
>
> - Mark VDDIO_AO18 always-on and link hdmi-supply to fix HDMI on boot
> - Add missing GPIO binding
> - Update LED bindings
>
> [...]

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v5.17/dt64)

[1/3] arm64: dts: meson-gxbb-wetek: fix HDMI in early boot
https://git.kernel.org/amlogic/c/8182a35868db5f053111d5d9d4da8fcb3f99259d
[2/3] arm64: dts: meson-gxbb-wetek: fix missing GPIO binding
https://git.kernel.org/amlogic/c/c019abb2feba3cbbd7cf7178f8e6499c4fa6fced
[3/3] arm64: dts: meson-gxbb-wetek: use updated LED bindings
https://git.kernel.org/amlogic/c/1e9fc71213d784dfbd153289daf08fdfc87f32ba

--
Neil