2021-10-12 09:20:37

by Vegard Nossum

Subject: [PATCH] net: arc: select CRC32

Fix the following build/link error by adding a dependency on the CRC32
routines:

ld: drivers/net/ethernet/arc/emac_main.o: in function `arc_emac_set_rx_mode':
emac_main.c:(.text+0xb11): undefined reference to `crc32_le'

The crc32_le() call comes through the ether_crc_le() call in
arc_emac_set_rx_mode().

Fixes: 775dd682e2b0ec ("arc_emac: implement promiscuous mode and multicast filtering")
Cc: Arnd Bergmann <[email protected]>
Signed-off-by: Vegard Nossum <[email protected]>
---
drivers/net/ethernet/arc/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/arc/Kconfig b/drivers/net/ethernet/arc/Kconfig
index 37a41773dd435..330185b624d03 100644
--- a/drivers/net/ethernet/arc/Kconfig
+++ b/drivers/net/ethernet/arc/Kconfig
@@ -6,6 +6,7 @@
config NET_VENDOR_ARC
bool "ARC devices"
default y
+ select CRC32
help
If you have a network (Ethernet) card belonging to this class, say Y.

--
2.23.0.718.g5ad94255a8

2021-10-12 09:37:25

by Vegard Nossum

Subject: [PATCH v2] net: arc: select CRC32

Fix the following build/link error by adding a dependency on the CRC32
routines:

ld: drivers/net/ethernet/arc/emac_main.o: in function `arc_emac_set_rx_mode':
emac_main.c:(.text+0xb11): undefined reference to `crc32_le'

The crc32_le() call comes through the ether_crc_le() call in
arc_emac_set_rx_mode().

[v2: moved the select to ARC_EMAC_CORE; the Makefile is a bit confusing,
but the error comes from emac_main.o, which is part of the arc_emac module,
which in turn is enabled by CONFIG_ARC_EMAC_CORE. Note that arc_emac is
different from emac_arc...]

Fixes: 775dd682e2b0ec ("arc_emac: implement promiscuous mode and multicast filtering")
Cc: Arnd Bergmann <[email protected]>
Signed-off-by: Vegard Nossum <[email protected]>
---
drivers/net/ethernet/arc/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/arc/Kconfig b/drivers/net/ethernet/arc/Kconfig
index 37a41773dd435..92a79c4ffa2c7 100644
--- a/drivers/net/ethernet/arc/Kconfig
+++ b/drivers/net/ethernet/arc/Kconfig
@@ -21,6 +21,7 @@ config ARC_EMAC_CORE
depends on ARC || ARCH_ROCKCHIP || COMPILE_TEST
select MII
select PHYLIB
+ select CRC32

config ARC_EMAC
tristate "ARC EMAC support"
--
2.23.0.718.g5ad94255a8

2021-10-13 16:23:11

by patchwork-bot+netdevbpf

Subject: Re: [PATCH v2] net: arc: select CRC32

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

On Tue, 12 Oct 2021 11:34:46 +0200 you wrote:
> Fix the following build/link error by adding a dependency on the CRC32
> routines:
>
> ld: drivers/net/ethernet/arc/emac_main.o: in function `arc_emac_set_rx_mode':
> emac_main.c:(.text+0xb11): undefined reference to `crc32_le'
>
> The crc32_le() call comes through the ether_crc_le() call in
> arc_emac_set_rx_mode().
>
> [...]

Here is the summary with links:
- [v2] net: arc: select CRC32
https://git.kernel.org/netdev/net/c/e599ee234ad4

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html