2021-10-12 15:27:53

by Vegard Nossum

Subject: [PATCH] net: korina: select CRC32

Fix the following build/link error by adding a dependency on the CRC32
routines:

ld: drivers/net/ethernet/korina.o: in function `korina_multicast_list':
korina.c:(.text+0x1af): undefined reference to `crc32_le'

Fixes: ef11291bcd5f9 ("Add support the Korina (IDT RC32434) Ethernet MAC")
Cc: Arnd Bergmann <[email protected]>
Signed-off-by: Vegard Nossum <[email protected]>
---
drivers/net/ethernet/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig
index d796684ec9ca0..412ae3e43ffb7 100644
--- a/drivers/net/ethernet/Kconfig
+++ b/drivers/net/ethernet/Kconfig
@@ -100,6 +100,7 @@ config JME
config KORINA
tristate "Korina (IDT RC32434) Ethernet support"
depends on MIKROTIK_RB532 || COMPILE_TEST
+ select CRC32
select MII
help
If you have a Mikrotik RouterBoard 500 or IDT RC32434
--
2.23.0.718.g5ad94255a8

2021-10-12 16:23:32

by Florian Fainelli

Subject: Re: [PATCH] net: korina: select CRC32

On 10/12/21 8:25 AM, Vegard Nossum wrote:
> Fix the following build/link error by adding a dependency on the CRC32
> routines:
>
> ld: drivers/net/ethernet/korina.o: in function `korina_multicast_list':
> korina.c:(.text+0x1af): undefined reference to `crc32_le'
>
> Fixes: ef11291bcd5f9 ("Add support the Korina (IDT RC32434) Ethernet MAC")
> Cc: Arnd Bergmann <[email protected]>
> Signed-off-by: Vegard Nossum <[email protected]>

Acked-by: Florian fainelli <[email protected]>
--
Florian

2021-10-13 20:41:48

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: korina: select CRC32

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

On Tue, 12 Oct 2021 17:25:09 +0200 you wrote:
> Fix the following build/link error by adding a dependency on the CRC32
> routines:
>
> ld: drivers/net/ethernet/korina.o: in function `korina_multicast_list':
> korina.c:(.text+0x1af): undefined reference to `crc32_le'
>
> Fixes: ef11291bcd5f9 ("Add support the Korina (IDT RC32434) Ethernet MAC")
> Cc: Arnd Bergmann <[email protected]>
> Signed-off-by: Vegard Nossum <[email protected]>
>
> [...]

Here is the summary with links:
- net: korina: select CRC32
https://git.kernel.org/netdev/net/c/427f974d9727

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html