2021-10-15 13:23:31

by Yang Li

[permalink] [raw]

Subject: [PATCH -next] drm/v3d: nullify pointer se with a NULL

---

Currently a plain integer is being used to nullify the pointer
struct v3d_submit_ext *se. Use NULL instead. Cleans up sparse
warnings:
drivers/gpu/drm/v3d/v3d_gem.c:777:53: warning: Using plain integer as
NULL pointer
drivers/gpu/drm/v3d/v3d_gem.c:1010:45: warning: Using plain integer as
NULL pointer

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/gpu/drm/v3d/v3d_gem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
index e47ae40..c7ed2e1 100644
--- a/drivers/gpu/drm/v3d/v3d_gem.c
+++ b/drivers/gpu/drm/v3d/v3d_gem.c
@@ -774,7 +774,7 @@ void v3d_job_put(struct v3d_job *job)

if (args->flags & DRM_V3D_SUBMIT_CL_FLUSH_CACHE) {
ret = v3d_job_init(v3d, file_priv, (void *)&clean_job, sizeof(*clean_job),
- v3d_job_free, 0, 0, V3D_CACHE_CLEAN);
+ v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
if (ret)
goto fail;

@@ -1007,7 +1007,7 @@ void v3d_job_put(struct v3d_job *job)
goto fail;

ret = v3d_job_init(v3d, file_priv, (void *)&clean_job, sizeof(*clean_job),
- v3d_job_free, 0, 0, V3D_CACHE_CLEAN);
+ v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
if (ret)
goto fail;

--
1.8.3.1

2021-10-16 09:36:26

by Melissa Wen

[permalink] [raw]

Subject: Re: [PATCH -next] drm/v3d: nullify pointer se with a NULL

---

On 10/15, Yang Li wrote:
> Currently a plain integer is being used to nullify the pointer
> struct v3d_submit_ext *se. Use NULL instead. Cleans up sparse
> warnings:
> drivers/gpu/drm/v3d/v3d_gem.c:777:53: warning: Using plain integer as
> NULL pointer
> drivers/gpu/drm/v3d/v3d_gem.c:1010:45: warning: Using plain integer as
> NULL pointer
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/gpu/drm/v3d/v3d_gem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
> index e47ae40..c7ed2e1 100644
> --- a/drivers/gpu/drm/v3d/v3d_gem.c
> +++ b/drivers/gpu/drm/v3d/v3d_gem.c
> @@ -774,7 +774,7 @@ void v3d_job_put(struct v3d_job *job)
>
> if (args->flags & DRM_V3D_SUBMIT_CL_FLUSH_CACHE) {
> ret = v3d_job_init(v3d, file_priv, (void *)&clean_job, sizeof(*clean_job),
> - v3d_job_free, 0, 0, V3D_CACHE_CLEAN);
> + v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
> if (ret)
> goto fail;
>
> @@ -1007,7 +1007,7 @@ void v3d_job_put(struct v3d_job *job)
> goto fail;
>
> ret = v3d_job_init(v3d, file_priv, (void *)&clean_job, sizeof(*clean_job),
> - v3d_job_free, 0, 0, V3D_CACHE_CLEAN);
> + v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
> if (ret)
> goto fail;

Thanks,

Reviewed-by: Melissa Wen <[email protected]>

and I'll apply do drm-misc-next.
>
> --
> 1.8.3.1
>

---

Attachments:

(No filename) (1.48 kB)
signature.asc (849.00 B)
Download all attachments