2021-10-18 03:38:40

by Sergio Paracuellos

Subject: [PATCH v5] dt-bindings: bus: add palmbus device tree bindings

Add device tree bindings for palmbus controller present in all the MIPS
ralink based SoCs.

Signed-off-by: Sergio Paracuellos <[email protected]>
---
changes in v5: Sent wrong patch in v4. Hence, properly sent it.
Changes in v4: The node name pattern is already checked elsewhere. There is only need to
define the unit-address part which should be lowercase hex.
Changes in v3: change sample to use child node which its bindings are
already in YAML format to make dtschema happier.
Changes in v2: fixed missing semicolon in example.
.../devicetree/bindings/bus/palmbus.yaml | 79 +++++++++++++++++++
1 file changed, 79 insertions(+)
.../devicetree/bindings/bus/palmbus.yaml | 79 +++++++++++++++++++
1 file changed, 79 insertions(+)
create mode 100644 Documentation/devicetree/bindings/bus/palmbus.yaml

diff --git a/Documentation/devicetree/bindings/bus/palmbus.yaml b/Documentation/devicetree/bindings/bus/palmbus.yaml
new file mode 100644
index 000000000000..f5cbfaf52d53
--- /dev/null
+++ b/Documentation/devicetree/bindings/bus/palmbus.yaml
@@ -0,0 +1,79 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bus/palmbus.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Ralink PalmBus Device Tree Bindings
+
+maintainers:
+ - Sergio Paracuellos <[email protected]>
+
+description: |
+ The ralink palmbus controller can be found in all ralink MIPS
+ SoCs. It provides an external bus for connecting multiple
+ external devices to the SoC.
+
+properties:
+ $nodename:
+ pattern: "^palmbus(@[0-9a-f]+)?$"
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 1
+
+ compatible:
+ const: palmbus
+
+ reg:
+ maxItems: 1
+
+ ranges: true
+
+patternProperties:
+ # All other properties should be child nodes with unit-address and 'reg'
+ "@[0-9a-f]+$":
+ type: object
+ properties:
+ reg:
+ maxItems: 1
+
+ required:
+ - reg
+
+required:
+ - compatible
+ - reg
+ - "#address-cells"
+ - "#size-cells"
+ - ranges
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/mips-gic.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+ palmbus@1e000000 {
+ compatible = "palmbus";
+ reg = <0x1e000000 0x100000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x1e000000 0x0fffff>;
+
+ gpio@600 {
+ #gpio-cells = <2>;
+ #interrupt-cells = <2>;
+ compatible = "mediatek,mt7621-gpio";
+ gpio-controller;
+ gpio-ranges = <&pinctrl 0 0 95>;
+ interrupt-controller;
+ reg = <0x600 0x100>;
+ interrupt-parent = <&gic>;
+ interrupts = <GIC_SHARED 12 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ };
+
+...
--
2.33.0

2021-10-18 16:56:29

by Rob Herring (Arm)

Subject: Re: [PATCH v5] dt-bindings: bus: add palmbus device tree bindings

On Sat, 16 Oct 2021 22:33:23 +0200, Sergio Paracuellos wrote:
> Add device tree bindings for palmbus controller present in all the MIPS
> ralink based SoCs.
>
> Signed-off-by: Sergio Paracuellos <[email protected]>
> ---
> changes in v5: Sent wrong patch in v4. Hence, properly sent it.
> Changes in v4: The node name pattern is already checked elsewhere. There is only need to
> define the unit-address part which should be lowercase hex.
> Changes in v3: change sample to use child node which its bindings are
> already in YAML format to make dtschema happier.
> Changes in v2: fixed missing semicolon in example.
> .../devicetree/bindings/bus/palmbus.yaml | 79 +++++++++++++++++++
> 1 file changed, 79 insertions(+)
> .../devicetree/bindings/bus/palmbus.yaml | 79 +++++++++++++++++++
> 1 file changed, 79 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/bus/palmbus.yaml
>

Reviewed-by: Rob Herring <[email protected]>

2021-10-18 17:01:43

by Rob Herring (Arm)

Subject: Re: [PATCH v5] dt-bindings: bus: add palmbus device tree bindings

On Sat, 16 Oct 2021 22:33:23 +0200, Sergio Paracuellos wrote:
> Add device tree bindings for palmbus controller present in all the MIPS
> ralink based SoCs.
>
> Signed-off-by: Sergio Paracuellos <[email protected]>
> ---
> changes in v5: Sent wrong patch in v4. Hence, properly sent it.
> Changes in v4: The node name pattern is already checked elsewhere. There is only need to
> define the unit-address part which should be lowercase hex.
> Changes in v3: change sample to use child node which its bindings are
> already in YAML format to make dtschema happier.
> Changes in v2: fixed missing semicolon in example.
> .../devicetree/bindings/bus/palmbus.yaml | 79 +++++++++++++++++++
> 1 file changed, 79 insertions(+)
> .../devicetree/bindings/bus/palmbus.yaml | 79 +++++++++++++++++++
> 1 file changed, 79 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/bus/palmbus.yaml
>

Applied, thanks!