2021-10-19 07:43:42

by Kavyasree Kotagiri

[permalink] [raw]
Subject: [PATCH v9 0/3] Add driver for lan966x Generic Clock Controller

This patch series adds a device driver for Generic Clock Controller
of lan966x SoC.

v8 -> v9:
- Added Acked-by to dt-bindings and Documentation file.
- Changed clk_name "timer" to "timer1"
- Updated devm_kzalloc in probe function.

v7 -> v8:
- Defined new constant DIV_MAX.
- Corrected and updated prescaler divider condition check.
- Added Acked-by.

v6 -> v7:
- Added Kconfig and Makefile entires for lan966x clock driver.

v5 -> v6:
- Added Acked-by to dt-bindings file.
- Removed "_clk" in clock-names.
- Added Reviewed-by to Documentation file.

v4 -> v5:
- In v4 dt-bindings, missed adding "clock-names" in required
properties and example. So, added them.
- Returning proper error - PTR_ERR.
- Removed unused variable "ret" in probe function.

v3 -> v4:
- Updated "clocks" and added "clock-names" in dt-bindings.
- Used clk_parent_data instead of of_clk_get_parent_name().

v2 -> v3:
- Fixed dt_binding_check errors.

v1 -> v2:
- Updated license in dt-bindings.
- Updated example provided for clock controller node.

Kavyasree Kotagiri (3):
dt-bindings: clock: lan966x: Add binding includes for lan966x SoC
clock IDs
dt-bindings: clock: lan966x: Add LAN966X Clock Controller
clk: lan966x: Add lan966x SoC clock driver

.../bindings/clock/microchip,lan966x-gck.yaml | 57 +++++
drivers/clk/Kconfig | 7 +
drivers/clk/Makefile | 1 +
drivers/clk/clk-lan966x.c | 240 ++++++++++++++++++
include/dt-bindings/clock/microchip,lan966x.h | 28 ++
5 files changed, 333 insertions(+)
create mode 100644 Documentation/devicetree/bindings/clock/microchip,lan966x-gck.yaml
create mode 100644 drivers/clk/clk-lan966x.c
create mode 100644 include/dt-bindings/clock/microchip,lan966x.h

--
2.17.1


2021-11-02 12:52:09

by Kavyasree Kotagiri

[permalink] [raw]
Subject: [PATCH v9 0/3] Add driver for lan966x Generic Clock Controller

Hi Stephen,

Could you please let me know if this patch series will be taken for 5.16?

Thanks,
Kavya
> -----Original Message-----
> From: Kavyasree Kotagiri [mailto:[email protected]]
> Sent: Tuesday, October 19, 2021 1:10 PM
> To: [email protected]; [email protected]; [email protected]
> Cc: Nicolas Ferre - M43238 <[email protected]>; linux-
> [email protected]; [email protected]; linux-
> [email protected]; UNGLinuxDriver <[email protected]>;
> Eugen Hristev - M18282 <[email protected]>; Kavyasree Kotagiri
> - I30978 <[email protected]>; Manohar Puri - I30488
> <[email protected]>
> Subject: [PATCH v9 0/3] Add driver for lan966x Generic Clock Controller
>
> This patch series adds a device driver for Generic Clock Controller
> of lan966x SoC.
>
> v8 -> v9:
> - Added Acked-by to dt-bindings and Documentation file.
> - Changed clk_name "timer" to "timer1"
> - Updated devm_kzalloc in probe function.
>
> v7 -> v8:
> - Defined new constant DIV_MAX.
> - Corrected and updated prescaler divider condition check.
> - Added Acked-by.
>
> v6 -> v7:
> - Added Kconfig and Makefile entires for lan966x clock driver.
>
> v5 -> v6:
> - Added Acked-by to dt-bindings file.
> - Removed "_clk" in clock-names.
> - Added Reviewed-by to Documentation file.
>
> v4 -> v5:
> - In v4 dt-bindings, missed adding "clock-names" in required
> properties and example. So, added them.
> - Returning proper error - PTR_ERR.
> - Removed unused variable "ret" in probe function.
>
> v3 -> v4:
> - Updated "clocks" and added "clock-names" in dt-bindings.
> - Used clk_parent_data instead of of_clk_get_parent_name().
>
> v2 -> v3:
> - Fixed dt_binding_check errors.
>
> v1 -> v2:
> - Updated license in dt-bindings.
> - Updated example provided for clock controller node.
>
> Kavyasree Kotagiri (3):
> dt-bindings: clock: lan966x: Add binding includes for lan966x SoC
> clock IDs
> dt-bindings: clock: lan966x: Add LAN966X Clock Controller
> clk: lan966x: Add lan966x SoC clock driver
>
> .../bindings/clock/microchip,lan966x-gck.yaml | 57 +++++
> drivers/clk/Kconfig | 7 +
> drivers/clk/Makefile | 1 +
> drivers/clk/clk-lan966x.c | 240 ++++++++++++++++++
> include/dt-bindings/clock/microchip,lan966x.h | 28 ++
> 5 files changed, 333 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/clock/microchip,lan966x-gck.yaml
> create mode 100644 drivers/clk/clk-lan966x.c
> create mode 100644 include/dt-bindings/clock/microchip,lan966x.h
>
> --
> 2.17.1

2021-11-02 21:54:54

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH v9 0/3] Add driver for lan966x Generic Clock Controller

Quoting [email protected] (2021-11-02 05:47:27)
> Hi Stephen,
>
> Could you please let me know if this patch series will be taken for 5.16?
>

One question on the driver but otherwise looks possible. I'll send
another PR next week.