2021-09-28 19:36:45

by Mianhan Liu

Subject: [PATCH -next] drivers/base/arch_topology.c: remove superfluous header

arch_topology.c hasn't use any macro or function declared in linux/percpu.h,
linux/smp.h and linux/string.h.
Thus, these files can be removed from arch_topology.c safely without
affecting the compilation of the drivers/base/ module

Signed-off-by: Mianhan Liu <[email protected]>

---
drivers/base/arch_topology.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
index 434076659..92200873b 100644
--- a/drivers/base/arch_topology.c
+++ b/drivers/base/arch_topology.c
@@ -12,15 +12,12 @@
#include <linux/device.h>
#include <linux/of.h>
#include <linux/slab.h>
-#include <linux/string.h>
#include <linux/sched/topology.h>
#include <linux/cpuset.h>
#include <linux/cpumask.h>
#include <linux/init.h>
-#include <linux/percpu.h>
#include <linux/rcupdate.h>
#include <linux/sched.h>
-#include <linux/smp.h>

static DEFINE_PER_CPU(struct scale_freq_data __rcu *, sft_data);
static struct cpumask scale_freq_counters_mask;
--
2.25.1

2021-10-19 09:25:52

by Sudeep Holla

Subject: Re: [PATCH -next] drivers/base/arch_topology.c: remove superfluous header

On Wed, Sep 29, 2021 at 03:31:38AM +0800, Mianhan Liu wrote:
> arch_topology.c hasn't use any macro or function declared in linux/percpu.h,
> linux/smp.h and linux/string.h.
> Thus, these files can be removed from arch_topology.c safely without
> affecting the compilation of the drivers/base/ module
>
> Signed-off-by: Mianhan Liu <[email protected]>
>
> ---
> drivers/base/arch_topology.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
> index 434076659..92200873b 100644
> --- a/drivers/base/arch_topology.c
> +++ b/drivers/base/arch_topology.c
> @@ -12,15 +12,12 @@
> #include <linux/device.h>
> #include <linux/of.h>
> #include <linux/slab.h>
> -#include <linux/string.h>
> #include <linux/sched/topology.h>
> #include <linux/cpuset.h>
> #include <linux/cpumask.h>
> #include <linux/init.h>
> -#include <linux/percpu.h>

Don't you need linux/percpu-defs.h for DEFINE_PER_CPU then ?

--
Regards,
Sudeep