2021-10-20 01:24:54

by CGEL

Subject: [PATCH] crash_dump: remove duplicate include in crash_dump.h

From: Ye Guojin <[email protected]>

'linux/pgtable.h' included in 'crash_dump.h' is duplicated.
it's also included at line 8.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Ye Guojin <[email protected]>
---
include/linux/crash_dump.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
index 0c547d866f1e..b7b255b23b99 100644
--- a/include/linux/crash_dump.h
+++ b/include/linux/crash_dump.h
@@ -8,8 +8,6 @@
#include <linux/pgtable.h>
#include <uapi/linux/vmcore.h>

-#include <linux/pgtable.h> /* for pgprot_t */
-
/* For IS_ENABLED(CONFIG_CRASH_DUMP) */
#define ELFCORE_ADDR_MAX (-1ULL)
#define ELFCORE_ADDR_ERR (-2ULL)
--
2.25.1

2021-10-20 01:56:35

by Baoquan He

Subject: Re: [PATCH] crash_dump: remove duplicate include in crash_dump.h

On 10/20/21 at 01:23am, [email protected] wrote:
> From: Ye Guojin <[email protected]>
>
> 'linux/pgtable.h' included in 'crash_dump.h' is duplicated.
> it's also included at line 8.

OK, in below commit the including order is adjusted, but the old one was
not removed.
commit 65fddcfca8ad("mm: reorder includes after introduction of linux/pgtable.h")

Could you rephrase the commit log? , the below sentences is for your reference.

============
In crash_dump.h, header file linux/pgtable.h is included twice. This
duplication was introduced in commit 65fddcfca8ad("mm: reorder includes
after introduction of linux/pgtable.h") where the order of include is
adjusted, while the old one was not removed.

Clean it up here.
============

Thanks for fixing this. when you finish polishing the patch log, please
feel free to add:

Acked-by: Baoquan He <[email protected]>

Thanks
Baoquan

>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Ye Guojin <[email protected]>
> ---
> include/linux/crash_dump.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index 0c547d866f1e..b7b255b23b99 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -8,8 +8,6 @@
> #include <linux/pgtable.h>
> #include <uapi/linux/vmcore.h>
>
> -#include <linux/pgtable.h> /* for pgprot_t */
> -
> /* For IS_ENABLED(CONFIG_CRASH_DUMP) */
> #define ELFCORE_ADDR_MAX (-1ULL)
> #define ELFCORE_ADDR_ERR (-2ULL)
> --
> 2.25.1
>

2021-10-20 09:10:32

by CGEL

Subject: [PATCH v2] crash_dump: remove duplicate include in crash_dump.h

From: Ye Guojin <[email protected]>

In crash_dump.h, header file <linux/pgtable.h> is included twice. This
duplication was introduced in commit 65fddcfca8ad("mm: reorder includes
after introduction of linux/pgtable.h") where the order of the header
files is adjusted, while the old one was not removed.

Clean it up here.

Reported-by: Zeal Robot <[email protected]>
Acked-by: Baoquan He <[email protected]>
Signed-off-by: Ye Guojin <[email protected]>
---
v2:
- update the commit log
---
include/linux/crash_dump.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
index 0c547d866f1e..b7b255b23b99 100644
--- a/include/linux/crash_dump.h
+++ b/include/linux/crash_dump.h
@@ -8,8 +8,6 @@
#include <linux/pgtable.h>
#include <uapi/linux/vmcore.h>

-#include <linux/pgtable.h> /* for pgprot_t */
-
/* For IS_ENABLED(CONFIG_CRASH_DUMP) */
#define ELFCORE_ADDR_MAX (-1ULL)
#define ELFCORE_ADDR_ERR (-2ULL)
--
2.25.1

2021-10-29 09:30:27

by Baoquan He

Subject: Re: [PATCH v2] crash_dump: remove duplicate include in crash_dump.h

On 10/20/21 at 09:06am, [email protected] wrote:
> From: Ye Guojin <[email protected]>
>
> In crash_dump.h, header file <linux/pgtable.h> is included twice. This
> duplication was introduced in commit 65fddcfca8ad("mm: reorder includes
> after introduction of linux/pgtable.h") where the order of the header
> files is adjusted, while the old one was not removed.
>
> Clean it up here.
>
> Reported-by: Zeal Robot <[email protected]>
> Acked-by: Baoquan He <[email protected]>
> Signed-off-by: Ye Guojin <[email protected]>

Thanks, add Andrew to CC.

> ---
> v2:
> - update the commit log
> ---
> include/linux/crash_dump.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index 0c547d866f1e..b7b255b23b99 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -8,8 +8,6 @@
> #include <linux/pgtable.h>
> #include <uapi/linux/vmcore.h>
>
> -#include <linux/pgtable.h> /* for pgprot_t */
> -
> /* For IS_ENABLED(CONFIG_CRASH_DUMP) */
> #define ELFCORE_ADDR_MAX (-1ULL)
> #define ELFCORE_ADDR_ERR (-2ULL)
> --
> 2.25.1
>