This is a driver for AX88796C Ethernet Adapter connected in SPI mode as
found on ARTIK5 evaluation board. The driver has been ported from a
v3.10.9 vendor kernel for ARTIK5 board.
Changes in v17:
- marked no_regs_list as const
- added myself as MODULE_AUTHOR()
- rearranged locking in ax88796c_close() to prevent race condition in
case ax88796c_work() wakes the queue after trasmission.
Changes in v16:
- rebased onto net-next 5.15-rc2 (7fec4d39198b)
Changes in v15:
- rebased onto net-next 5.14-rc2 (268ca4129d8d)
- added explicit cast of le16_to_cpus() argument to u16*
(reported by: kernel test robot <[email protected]>)
- removed invalid and superfluous call to u64_stats_init()
(reported by: Jakub Kicinski <[email protected]>)
Changes in v14:
- rebased onto net-next 5.14-rc1 (0d6835ffe50c)
Changes in v13:
- rebased onto net-next (ebbf5fcb94a7)
- minor fix: use u64_stats_update_{begin_irqsave,end_irqrestore}
- minor fix: initialize the syncp lock
Changes in v12:
- rebased to net-next-5.13
- added missing spaces after commas
- corrected indentation
Changes in v11:
- changed stat counters to 64-bit
- replaced WARN_ON(!mutex_is_locked()) with lockdep_assert_held()
- replaced ax88796c_free_skb_queue() with __skb_queue_purge()
- added cancel_work_sync() for ax_work
- removed unused fields of struct skb_data
- replaced MAX() with max() from minmax.h
- rebased to net-next (resend)
Changes in v10:
- removed unused variable
Changes in v9:
- used pskb_extend_head()
- used ethtool private flags instead of tunables to switch SPI
compression
- changed
- alloc_skb() to netdev_alloc(skb)
- __pskb_trim() to pskb_trim()
- removed:
- chages to skb->truesize
- unnecessary casting to short
- return f() in a void function
- IRQF_SHARED flags
- unnecessary memset(0) of kzalloc()ed buffer
- unused endiannes detection
- unnecessary __packed attribute for some structures
- added:
- temporary variable in AX_WRITE/READ sequences
- missin mutex_unlock() in error paths
- axspi_read_reg() returns a constant value in case of an error
Changes in v8:
- fixed the entry in MAINTAINERS
- removed unnecessary netif_err()
- changed netif_rx() to netif_rx_ni() for code running in a process
context
- added explicit type casting for ~BIT()
Changes in v7:
- removed duplicate code
- moved a constant buffer definition away from a header file
Changes in v6:
- fixed typos in Kconfig
- checked argument value in ax88796c_set_tunable
- updated tags in commit messages
Changes in v5:
- coding style (local variable declarations)
- added spi0 node in the DT binding example and removed
interrupt-parent
- removed comp module parameter
- added CONFIG_SPI_AX88796C_COMPRESSION option to set the initial
state of SPI compression
- introduced new ethtool tunable "spi-compression" to control SPI
transfer compression
- removed unused fields in struct ax88796c_device
- switched from using buffers allocated on stack for SPI transfers
to DMA safe ones embedded in struct ax_spi and allocated with
kmalloc()
Changes in v4:
- fixed compilation problems in asix,ax88796c.yaml and in
ax88796c_main.c introduced in v3
Changes in v3:
- modify vendor-prefixes.yaml in a separate patch
- fix several problems in the dt binding
- removed unnecessary descriptions and properties
- changed the order of entries
- fixed problems with missing defines in the example
- change (1 << N) to BIT(N), left a few (0 << N)
- replace ax88796c_get_link(), ax88796c_get_link_ksettings(),
ax88796c_set_link_ksettings(), ax88796c_nway_reset(),
ax88796c_set_mac_address() with appropriate kernel functions.
- disable PHY auto-polling in MAC and use PHYLIB to track the state
of PHY and configure MAC
- propagate return values instead of returning constants in several
places
- add WARN_ON() for unlocked mutex
- remove local work queue and use the system_wq
- replace phy_connect_direct() with phy_connect() and move
devm_register_netdev() to the end of ax88796c_probe()
(Unlike phy_connect_direct() phy_connect() does not crash if the
network device isn't registered yet.)
- remove error messages on ENOMEM
- move free_irq() to the end of ax88796c_close() to avoid race
condition
- implement flow-control
Changes in v2:
- use phylib
- added DT bindings
- moved #includes to *.c files
- used mutex instead of a semaphore for locking
- renamed some constants
- added error propagation for several functions
- used ethtool for dumping registers
- added control over checksum offloading
- remove vendor specific PM
- removed macaddr module parameter and added support for reading a MAC
address from platform data (e.g. DT)
- removed dependency on SPI from NET_VENDOR_ASIX
- added an entry in the MAINTAINERS file
- simplified logging with appropriate netif_* and netdev_* helpers
- lots of style fixes
Łukasz Stelmach (3):
dt-bindings: vendor-prefixes: Add asix prefix
dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter
net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver
.../bindings/net/asix,ax88796c.yaml | 73 ++
.../devicetree/bindings/vendor-prefixes.yaml | 2 +
MAINTAINERS | 6 +
drivers/net/ethernet/Kconfig | 1 +
drivers/net/ethernet/Makefile | 1 +
drivers/net/ethernet/asix/Kconfig | 35 +
drivers/net/ethernet/asix/Makefile | 6 +
drivers/net/ethernet/asix/ax88796c_ioctl.c | 239 ++++
drivers/net/ethernet/asix/ax88796c_ioctl.h | 26 +
drivers/net/ethernet/asix/ax88796c_main.c | 1163 +++++++++++++++++
drivers/net/ethernet/asix/ax88796c_main.h | 568 ++++++++
drivers/net/ethernet/asix/ax88796c_spi.c | 115 ++
drivers/net/ethernet/asix/ax88796c_spi.h | 69 +
13 files changed, 2304 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/asix,ax88796c.yaml
create mode 100644 drivers/net/ethernet/asix/Kconfig
create mode 100644 drivers/net/ethernet/asix/Makefile
create mode 100644 drivers/net/ethernet/asix/ax88796c_ioctl.c
create mode 100644 drivers/net/ethernet/asix/ax88796c_ioctl.h
create mode 100644 drivers/net/ethernet/asix/ax88796c_main.c
create mode 100644 drivers/net/ethernet/asix/ax88796c_main.h
create mode 100644 drivers/net/ethernet/asix/ax88796c_spi.c
create mode 100644 drivers/net/ethernet/asix/ax88796c_spi.h
--
2.30.2
Add bindings for AX88796C SPI Ethernet Adapter.
Signed-off-by: Łukasz Stelmach <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/net/asix,ax88796c.yaml | 73 +++++++++++++++++++
1 file changed, 73 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/asix,ax88796c.yaml
diff --git a/Documentation/devicetree/bindings/net/asix,ax88796c.yaml b/Documentation/devicetree/bindings/net/asix,ax88796c.yaml
new file mode 100644
index 000000000000..699ebf452479
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/asix,ax88796c.yaml
@@ -0,0 +1,73 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/asix,ax88796c.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ASIX AX88796C SPI Ethernet Adapter
+
+maintainers:
+ - Łukasz Stelmach <[email protected]>
+
+description: |
+ ASIX AX88796C is an Ethernet controller with a built in PHY. This
+ describes SPI mode of the chip.
+
+ The node for this driver must be a child node of an SPI controller,
+ hence all mandatory properties described in
+ ../spi/spi-controller.yaml must be specified.
+
+allOf:
+ - $ref: ethernet-controller.yaml#
+
+properties:
+ compatible:
+ const: asix,ax88796c
+
+ reg:
+ maxItems: 1
+
+ spi-max-frequency:
+ maximum: 40000000
+
+ interrupts:
+ maxItems: 1
+
+ reset-gpios:
+ description:
+ A GPIO line handling reset of the chip. As the line is active low,
+ it should be marked GPIO_ACTIVE_LOW.
+ maxItems: 1
+
+ local-mac-address: true
+
+ mac-address: true
+
+required:
+ - compatible
+ - reg
+ - spi-max-frequency
+ - interrupts
+ - reset-gpios
+
+additionalProperties: false
+
+examples:
+ # Artik5 eval board
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/gpio/gpio.h>
+ spi0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethernet@0 {
+ compatible = "asix,ax88796c";
+ reg = <0x0>;
+ local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
+ interrupt-parent = <&gpx2>;
+ interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+ spi-max-frequency = <40000000>;
+ reset-gpios = <&gpe0 2 GPIO_ACTIVE_LOW>;
+ };
+ };
--
2.30.2
Hello:
This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:
On Wed, 20 Oct 2021 20:24:19 +0200 you wrote:
> This is a driver for AX88796C Ethernet Adapter connected in SPI mode as
> found on ARTIK5 evaluation board. The driver has been ported from a
> v3.10.9 vendor kernel for ARTIK5 board.
>
> Changes in v17:
> - marked no_regs_list as const
> - added myself as MODULE_AUTHOR()
> - rearranged locking in ax88796c_close() to prevent race condition in
> case ax88796c_work() wakes the queue after trasmission.
>
> [...]
Here is the summary with links:
- [net-next,v17,1/3] dt-bindings: vendor-prefixes: Add asix prefix
https://git.kernel.org/netdev/net-next/c/4def0acb63ce
- [net-next,v17,2/3] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter
https://git.kernel.org/netdev/net-next/c/b13c7a88a7b6
- [net-next,v17,3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver
https://git.kernel.org/netdev/net-next/c/a97c69ba4f30
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html