2021-10-21 13:05:03

by Thomas Weißschuh

Subject: [PATCH] ipvs: autoload ipvs on genl access

The kernel provides the functionality to automatically load modules
providing genl families. Use this to remove the need for users to
manually load the module.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
net/netfilter/ipvs/ip_vs_ctl.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
index 29ec3ef63edc..0ff94c66641f 100644
--- a/net/netfilter/ipvs/ip_vs_ctl.c
+++ b/net/netfilter/ipvs/ip_vs_ctl.c
@@ -48,6 +48,8 @@

#include <net/ip_vs.h>

+MODULE_ALIAS_GENL_FAMILY(IPVS_GENL_NAME);
+
/* semaphore for IPVS sockopts. And, [gs]etsockopt may sleep. */
static DEFINE_MUTEX(__ip_vs_mutex);


base-commit: d9aaaf223297f6146d9d7f36caca927c92ab855a
--
2.33.1

2021-10-21 18:34:59

by Julian Anastasov

Subject: Re: [PATCH] ipvs: autoload ipvs on genl access

Hello,

On Thu, 21 Oct 2021, Thomas Weißschuh wrote:

> The kernel provides the functionality to automatically load modules
> providing genl families. Use this to remove the need for users to
> manually load the module.
>
> Signed-off-by: Thomas Weißschuh <[email protected]>

Looks good to me for -next tree, thanks!

Acked-by: Julian Anastasov <[email protected]>

> ---
> net/netfilter/ipvs/ip_vs_ctl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> index 29ec3ef63edc..0ff94c66641f 100644
> --- a/net/netfilter/ipvs/ip_vs_ctl.c
> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
> @@ -48,6 +48,8 @@
>
> #include <net/ip_vs.h>
>
> +MODULE_ALIAS_GENL_FAMILY(IPVS_GENL_NAME);
> +
> /* semaphore for IPVS sockopts. And, [gs]etsockopt may sleep. */
> static DEFINE_MUTEX(__ip_vs_mutex);
>
>
> base-commit: d9aaaf223297f6146d9d7f36caca927c92ab855a
> --
> 2.33.1

Regards

--
Julian Anastasov <[email protected]>

2021-10-22 11:28:26

by Simon Horman

Subject: Re: [PATCH] ipvs: autoload ipvs on genl access

On Thu, Oct 21, 2021 at 09:24:34PM +0300, Julian Anastasov wrote:
>
> Hello,
>
> On Thu, 21 Oct 2021, Thomas Weißschuh wrote:
>
> > The kernel provides the functionality to automatically load modules
> > providing genl families. Use this to remove the need for users to
> > manually load the module.
> >
> > Signed-off-by: Thomas Weißschuh <[email protected]>
>
> Looks good to me for -next tree, thanks!
>
> Acked-by: Julian Anastasov <[email protected]>

Acked-by: Simon Horman <[email protected]>

2021-10-22 12:13:56

by Pablo Neira Ayuso

Subject: Re: [PATCH] ipvs: autoload ipvs on genl access

On Thu, Oct 21, 2021 at 03:02:55PM +0200, Thomas Weißschuh wrote:
> The kernel provides the functionality to automatically load modules
> providing genl families. Use this to remove the need for users to
> manually load the module.

Applied, thanks