2021-10-25 01:55:00

by Brad Larson

Subject: [PATCH v3 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC

Document the cadence qspi controller compatible for Pensando Elba SoC
boards. The Elba qspi fifo size is 1024.

Signed-off-by: Brad Larson <[email protected]>
---
Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
index 0e7087cc8bf9..d4413eced17a 100644
--- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
+++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
@@ -20,6 +20,7 @@ properties:
- ti,k2g-qspi
- ti,am654-ospi
- intel,lgm-qspi
+ - pensando,elba-qspi
- const: cdns,qspi-nor
- const: cdns,qspi-nor

@@ -38,7 +39,7 @@ properties:
description:
Size of the data FIFO in words.
$ref: "/schemas/types.yaml#/definitions/uint32"
- enum: [ 128, 256 ]
+ enum: [ 128, 256, 1024 ]
default: 128

cdns,fifo-width:
--
2.17.1

2021-10-27 22:16:53

by Rob Herring (Arm)

Subject: Re: [PATCH v3 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC

On Sun, 24 Oct 2021 18:51:49 -0700, Brad Larson wrote:
> Document the cadence qspi controller compatible for Pensando Elba SoC
> boards. The Elba qspi fifo size is 1024.
>
> Signed-off-by: Brad Larson <[email protected]>
> ---
> Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>

Acked-by: Rob Herring <[email protected]>

2021-10-28 07:27:51

by Serge Semin

Subject: Re: [PATCH v3 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC

Hello Brad

The patch name "dt-bindings: spi: Add compatible for Pensando Elba
SoC" doesn't mention to what bindings it is referring to. For the sake
of having a more representative git log I'd suggest at least to add
"cdns" vendor name in the title, like: "dt-bindings: spi: cdns: Add ..."
Otherwise it's impossible to understand to what bindings you're adding
a new compatibility especially seeing you are doing the similar thing
for the DW SPI in the next patch.

-Sergey

On Sun, Oct 24, 2021 at 06:51:49PM -0700, Brad Larson wrote:
> Document the cadence qspi controller compatible for Pensando Elba SoC
> boards. The Elba qspi fifo size is 1024.
>
> Signed-off-by: Brad Larson <[email protected]>
> ---
> Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> index 0e7087cc8bf9..d4413eced17a 100644
> --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> @@ -20,6 +20,7 @@ properties:
> - ti,k2g-qspi
> - ti,am654-ospi
> - intel,lgm-qspi
> + - pensando,elba-qspi
> - const: cdns,qspi-nor
> - const: cdns,qspi-nor
>
> @@ -38,7 +39,7 @@ properties:
> description:
> Size of the data FIFO in words.
> $ref: "/schemas/types.yaml#/definitions/uint32"
> - enum: [ 128, 256 ]
> + enum: [ 128, 256, 1024 ]
> default: 128
>
> cdns,fifo-width:
> --
> 2.17.1
>

2021-11-16 00:11:52

by Brad Larson

Subject: Re: [PATCH v3 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC

Hi Sergey,

On Thu, Oct 28, 2021 at 12:26 AM Serge Semin <[email protected]> wrote:
>
> Hello Brad
>
> The patch name "dt-bindings: spi: Add compatible for Pensando Elba
> SoC" doesn't mention to what bindings it is referring to. For the sake
> of having a more representative git log I'd suggest at least to add
> "cdns" vendor name in the title, like: "dt-bindings: spi: cdns: Add ..."
> Otherwise it's impossible to understand to what bindings you're adding
> a new compatibility especially seeing you are doing the similar thing
> for the DW SPI in the next patch.

I'll add "cdns" to the git log for the re-spin.

Thanks
Brad