2021-10-27 11:28:37

by Dongli Zhang

Subject: [PATCH 1/1] vmxnet3: do not stop tx queues after netif_device_detach()

The netif_device_detach() conditionally stops all tx queues if the queues
are running. There is no need to call netif_tx_stop_all_queues() again.

Signed-off-by: Dongli Zhang <[email protected]>
---
While I do not have vmware env, I did test with QEMU + vmxnet3.

drivers/net/vmxnet3/vmxnet3_drv.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 142f70670f5c..8799854bacb2 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -3833,7 +3833,6 @@ vmxnet3_suspend(struct device *device)
vmxnet3_free_intr_resources(adapter);

netif_device_detach(netdev);
- netif_tx_stop_all_queues(netdev);

/* Create wake-up filters. */
pmConf = adapter->pm_conf;
--
2.17.1

2021-10-28 12:01:26

by patchwork-bot+netdevbpf

Subject: Re: [PATCH 1/1] vmxnet3: do not stop tx queues after netif_device_detach()

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

On Tue, 26 Oct 2021 14:50:31 -0700 you wrote:
> The netif_device_detach() conditionally stops all tx queues if the queues
> are running. There is no need to call netif_tx_stop_all_queues() again.
>
> Signed-off-by: Dongli Zhang <[email protected]>
> ---
> While I do not have vmware env, I did test with QEMU + vmxnet3.
>
> [...]

Here is the summary with links:
- [1/1] vmxnet3: do not stop tx queues after netif_device_detach()
https://git.kernel.org/netdev/net/c/9159f102402a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html