2021-10-28 21:19:27

by Jarrett Schultz

Subject: [PATCH 1/3] dt-bindings: platform: microsoft: Document surface xbl

Introduce yaml for surface xbl driver.

Signed-off-by: Jarrett Schultz <[email protected]>
---
.../platform/microsoft/surface-xbl.yaml | 37 +++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 Documentation/devicetree/bindings/platform/microsoft/surface-xbl.yaml

diff --git a/Documentation/devicetree/bindings/platform/microsoft/surface-xbl.yaml b/Documentation/devicetree/bindings/platform/microsoft/surface-xbl.yaml
new file mode 100644
index 000000000000..3d2771322e72
--- /dev/null
+++ b/Documentation/devicetree/bindings/platform/microsoft/surface-xbl.yaml
@@ -0,0 +1,37 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/platform/microsoft/surface-xbl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Surface Extensible Bootloader for Microsoft Surface Duo
+
+maintainers:
+ - Jarrett Schultz <[email protected]>
+
+description: |
+ Exposes device information to user space.
+
+allOf:
+ - $ref: /schemas/platform/microsoft/surface-xbl.c#
+
+properties:
+ compatible:
+ const: microsoft,sm8150-surface-duo-xbl
+
+ reg:
+ maxItems: 1
+
+unevaluatedProperties: false
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+examples:
+ - |
+ xbl@146bfa94 {
+ compatible = "microsoft,sm8150-surface-duo-xbl";
+ reg = <0x00 0x146bfa94 0x00 0x100>;
+ };
--
2.25.1

2021-10-28 21:59:23

by Rob Herring

Subject: Re: [PATCH 1/3] dt-bindings: platform: microsoft: Document surface xbl

On Thu, Oct 28, 2021 at 4:18 PM Jarrett Schultz <[email protected]> wrote:
>
> Introduce yaml for surface xbl driver.

What's surface? What's xbl? Bindings are for h/w devices, not drivers.

Please send DT patches to the DT list. IOW, run get_maintainers.pl.

>
> Signed-off-by: Jarrett Schultz <[email protected]>
> ---
> .../platform/microsoft/surface-xbl.yaml | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/platform/microsoft/surface-xbl.yaml
>
> diff --git a/Documentation/devicetree/bindings/platform/microsoft/surface-xbl.yaml b/Documentation/devicetree/bindings/platform/microsoft/surface-xbl.yaml
> new file mode 100644
> index 000000000000..3d2771322e72
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/platform/microsoft/surface-xbl.yaml
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: GPL-2.0

Dual license please. Run checkpatch.pl as that will tell you this.

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/platform/microsoft/surface-xbl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Surface Extensible Bootloader for Microsoft Surface Duo
> +
> +maintainers:
> + - Jarrett Schultz <[email protected]>
> +
> +description: |
> + Exposes device information to user space.

What does that mean?

> +
> +allOf:
> + - $ref: /schemas/platform/microsoft/surface-xbl.c#

You have a C file with json-schema?

> +
> +properties:
> + compatible:
> + const: microsoft,sm8150-surface-duo-xbl
> +
> + reg:
> + maxItems: 1
> +
> +unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +examples:
> + - |
> + xbl@146bfa94 {
> + compatible = "microsoft,sm8150-surface-duo-xbl";
> + reg = <0x00 0x146bfa94 0x00 0x100>;

That's an odd address. Is this part of some other block?

> + };
> --
> 2.25.1
>

2021-10-28 22:52:34

by Bjorn Andersson

Subject: Re: [PATCH 1/3] dt-bindings: platform: microsoft: Document surface xbl

On Thu 28 Oct 14:17 PDT 2021, Jarrett Schultz wrote:

> Introduce yaml for surface xbl driver.
>
> Signed-off-by: Jarrett Schultz <[email protected]>
> ---
> .../platform/microsoft/surface-xbl.yaml | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/platform/microsoft/surface-xbl.yaml
>
> diff --git a/Documentation/devicetree/bindings/platform/microsoft/surface-xbl.yaml b/Documentation/devicetree/bindings/platform/microsoft/surface-xbl.yaml
> new file mode 100644
> index 000000000000..3d2771322e72
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/platform/microsoft/surface-xbl.yaml
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/platform/microsoft/surface-xbl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Surface Extensible Bootloader for Microsoft Surface Duo
> +
> +maintainers:
> + - Jarrett Schultz <[email protected]>
> +
> +description: |
> + Exposes device information to user space.
> +
> +allOf:
> + - $ref: /schemas/platform/microsoft/surface-xbl.c#
> +
> +properties:
> + compatible:
> + const: microsoft,sm8150-surface-duo-xbl
> +
> + reg:
> + maxItems: 1
> +
> +unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +examples:
> + - |
> + xbl@146bfa94 {
> + compatible = "microsoft,sm8150-surface-duo-xbl";
> + reg = <0x00 0x146bfa94 0x00 0x100>;

I believe this is in the middle of IMEM. If so it would be better to
describe the entire IMEM section in one block and then list this as one
of the pieces within.

Please see e.g. imem@146aa000 in sc7180.dtsi

Thanks,
Bjorn

> + };
> --
> 2.25.1
>