2021-10-29 15:43:39

by Adrian Ratiu

[permalink] [raw]
Subject: [PATCH v2] arm64: defconfig: enable regulator to fix mt8173 regression

A regression was introduced on some mediatek boards starting with
v5.15-rc1 in commit 109fd20601e2 ("arm64: dts: mediatek: mt8173:
Add domain supply for mfg_async") which effectively changed the
regulator from the always-on dummy to DA9211 without explicitely
enabling it, causing failures caught by KernelCI on Hana
Chromebooks [1] for previously used dummies like:

mtk-power-controller 10006000.syscon:power-controller: supply domain not found, using dummy regulator
mtu3 11271000.usb: supply vbus not found, using dummy regulator
xhci-mtk 11270000.usb: supply vbus not found, using dummy regulator

There might be another bug linking these power domains in the
mediatek PM driver, but that is a separate issue wich needs
addressing, for now just fix the obvious regression due to the
new regulator requirement.

[1] https://github.com/kernelci/kernelci-project/issues/66
Fixes: 109fd20601e2 ("arm64: dts: mediatek: mt8173: Add domain supply for mfg_async")
Reported-by: "kernelci.org bot" <[email protected]>
Cc: Guillaume Tucker <[email protected]>
Suggested-by: Enric Balletbo Serra <[email protected]>
Signed-off-by: Adrian Ratiu <[email protected]>
---

Changes in v2:
* Added Fixes tag
* Slight rewording of commit msg to improve clarity

---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 545197bc0501..fb82971ff654 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -615,6 +615,7 @@ CONFIG_REGULATOR_FIXED_VOLTAGE=y
CONFIG_REGULATOR_AXP20X=y
CONFIG_REGULATOR_BD718XX=y
CONFIG_REGULATOR_BD9571MWV=y
+CONFIG_REGULATOR_DA9211=y
CONFIG_REGULATOR_FAN53555=y
CONFIG_REGULATOR_GPIO=y
CONFIG_REGULATOR_HI6421V530=y
--
2.33.1


Subject: Re: [PATCH v2] arm64: defconfig: enable regulator to fix mt8173 regression

Il 29/10/21 17:39, Adrian Ratiu ha scritto:
> A regression was introduced on some mediatek boards starting with
> v5.15-rc1 in commit 109fd20601e2 ("arm64: dts: mediatek: mt8173:
> Add domain supply for mfg_async") which effectively changed the
> regulator from the always-on dummy to DA9211 without explicitely
> enabling it, causing failures caught by KernelCI on Hana
> Chromebooks [1] for previously used dummies like:
>
> mtk-power-controller 10006000.syscon:power-controller: supply domain not found, using dummy regulator
> mtu3 11271000.usb: supply vbus not found, using dummy regulator
> xhci-mtk 11270000.usb: supply vbus not found, using dummy regulator
>
> There might be another bug linking these power domains in the
> mediatek PM driver, but that is a separate issue wich needs
> addressing, for now just fix the obvious regression due to the
> new regulator requirement.
>
> [1] https://github.com/kernelci/kernelci-project/issues/66
> Fixes: 109fd20601e2 ("arm64: dts: mediatek: mt8173: Add domain supply for mfg_async")
> Reported-by: "kernelci.org bot" <[email protected]>
> Cc: Guillaume Tucker <[email protected]>
> Suggested-by: Enric Balletbo Serra <[email protected]>
> Signed-off-by: Adrian Ratiu <[email protected]>

Tested-by: AngeloGioacchino Del Regno <[email protected]>