2021-10-29 19:08:58

by David Heidelberg

[permalink] [raw]
Subject: [PATCH] dt-bindings: sound: gtm601: convert to YAML

Convert GTM601 binding to the YAML format.

Signed-off-by: David Heidelberg <[email protected]>
---
.../devicetree/bindings/sound/gtm601.txt | 19 -----------
.../devicetree/bindings/sound/gtm601.yaml | 33 +++++++++++++++++++
2 files changed, 33 insertions(+), 19 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/sound/gtm601.txt
create mode 100644 Documentation/devicetree/bindings/sound/gtm601.yaml

diff --git a/Documentation/devicetree/bindings/sound/gtm601.txt b/Documentation/devicetree/bindings/sound/gtm601.txt
deleted file mode 100644
index efa32a486c4a..000000000000
--- a/Documentation/devicetree/bindings/sound/gtm601.txt
+++ /dev/null
@@ -1,19 +0,0 @@
-GTM601 UMTS modem audio interface CODEC
-
-This device has no configuration interface. The sample rate and channels are
-based on the compatible string
- "option,gtm601" = 8kHz mono
- "broadmobi,bm818" = 48KHz stereo
-
-Required properties:
-
- - compatible : one of
- "option,gtm601"
- "broadmobi,bm818"
-
-
-Example:
-
-codec: gtm601_codec {
- compatible = "option,gtm601";
-};
diff --git a/Documentation/devicetree/bindings/sound/gtm601.yaml b/Documentation/devicetree/bindings/sound/gtm601.yaml
new file mode 100644
index 000000000000..804402c72798
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/gtm601.yaml
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/gtm601.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: GTM601 UMTS modem audio interface CODEC
+
+maintainers:
+ - Angus Ainslie (Purism) <[email protected]>
+
+description: >
+ This device has no configuration interface. The sample rate and channels are
+ based on the compatible string
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - const: broadmobi,bm818
+ - const: option,gtm601
+ - items:
+ - enum:
+ - broadmobi,bm818 # 48 kHz stereo
+ - option,gtm601 # 8 kHz mono
+
+additionalProperties: false
+
+examples:
+ - |
+ gtm601_codec {
+ compatible = "option,gtm601";
+ };
--
2.33.0


2021-10-29 21:17:37

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: sound: gtm601: convert to YAML

On Fri, 29 Oct 2021 19:54:17 +0200, David Heidelberg wrote:
> Convert GTM601 binding to the YAML format.
>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
> .../devicetree/bindings/sound/gtm601.txt | 19 -----------
> .../devicetree/bindings/sound/gtm601.yaml | 33 +++++++++++++++++++
> 2 files changed, 33 insertions(+), 19 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/gtm601.txt
> create mode 100644 Documentation/devicetree/bindings/sound/gtm601.yaml
>

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1548195


gsm_codec: '#sound-dai-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/omap3-gta04a3.dt.yaml
arch/arm/boot/dts/omap3-gta04a4.dt.yaml
arch/arm/boot/dts/omap3-gta04a5.dt.yaml
arch/arm/boot/dts/omap3-gta04a5one.dt.yaml

sound-wwan-codec: '#sound-dai-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dt.yaml
arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml
arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dt.yaml
arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dt.yaml