2021-10-21 10:48:26

by Mauro Carvalho Chehab

Subject: [PATCH v15 13/13] PCI: kirin: Allow removing the driver

Now that everything is in place at the poweroff sequence,
this driver can use module_platform_driver(), which allows
it to be removed.

Acked-by: Xiaowei Song <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v15 00/13] at: https://lore.kernel.org/all/[email protected]/

drivers/pci/controller/dwc/pcie-kirin.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controller/dwc/pcie-kirin.c
index fea4d717fff3..cdf568ea0f68 100644
--- a/drivers/pci/controller/dwc/pcie-kirin.c
+++ b/drivers/pci/controller/dwc/pcie-kirin.c
@@ -827,7 +827,7 @@ static struct platform_driver kirin_pcie_driver = {
.suppress_bind_attrs = true,
},
};
-builtin_platform_driver(kirin_pcie_driver);
+module_platform_driver(kirin_pcie_driver);

MODULE_DEVICE_TABLE(of, kirin_pcie_match);
MODULE_DESCRIPTION("PCIe host controller driver for Kirin Phone SoCs");
--
2.31.1

2021-10-31 20:57:06

by Pali Rohár

Subject: Re: [PATCH v15 13/13] PCI: kirin: Allow removing the driver

On Thursday 21 October 2021 11:45:20 Mauro Carvalho Chehab wrote:
> Now that everything is in place at the poweroff sequence,
> this driver can use module_platform_driver(), which allows
> it to be removed.
>
> Acked-by: Xiaowei Song <[email protected]>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> ---
>
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v15 00/13] at: https://lore.kernel.org/all/[email protected]/
>
> drivers/pci/controller/dwc/pcie-kirin.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controller/dwc/pcie-kirin.c
> index fea4d717fff3..cdf568ea0f68 100644
> --- a/drivers/pci/controller/dwc/pcie-kirin.c
> +++ b/drivers/pci/controller/dwc/pcie-kirin.c
> @@ -827,7 +827,7 @@ static struct platform_driver kirin_pcie_driver = {
> .suppress_bind_attrs = true,

Hello Mauro! I think that you should not set ".suppress_bind_attrs" to
"true" if you want to bind and unbind driver at runtime.

> },
> };
> -builtin_platform_driver(kirin_pcie_driver);
> +module_platform_driver(kirin_pcie_driver);
>
> MODULE_DEVICE_TABLE(of, kirin_pcie_match);
> MODULE_DESCRIPTION("PCIe host controller driver for Kirin Phone SoCs");
> --
> 2.31.1
>