2021-10-29 00:55:06

by Dennis Gilmore

Subject: [PATCH] arm64: dts: rockchip: helios64: add variables for pcie completion

without ep-gpios defined u-boot does not initialise PCIe
rockchip_pcie pcie@f8000000: failed to find ep-gpios property

additionally set max-link-speed and pinctrl-names for completeness

with this patch and the ones from Florian Klink applied to the dts
file in u-boot sata drives show up in both u-boot and linux

Signed-off-by: Dennis Gilmore <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
index 9c2b45012daa..1e4042a7fdc3 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
@@ -534,7 +534,10 @@ &pcie_phy {
};

&pcie0 {
+ ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
+ max-link-speed = <2>;
num-lanes = <2>;
+ pinctrl-names = "default";
status = "okay";

vpcie12v-supply = <&vcc12v_dcin>;
--
2.32.0

2021-11-01 09:52:47

by Florian Klink

Subject: Re: [PATCH] arm64: dts: rockchip: helios64: add variables for pcie completion

Acked-By: Florian Klink <[email protected]>

On 21-10-28 19:53:19, Dennis Gilmore wrote:
>without ep-gpios defined u-boot does not initialise PCIe
>rockchip_pcie pcie@f8000000: failed to find ep-gpios property
>
>additionally set max-link-speed and pinctrl-names for completeness
>
>with this patch and the ones from Florian Klink applied to the dts
>file in u-boot sata drives show up in both u-boot and linux
>
>Signed-off-by: Dennis Gilmore <[email protected]>
>---
> arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
>index 9c2b45012daa..1e4042a7fdc3 100644
>--- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
>+++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
>@@ -534,7 +534,10 @@ &pcie_phy {
> };
>
> &pcie0 {
>+ ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
>+ max-link-speed = <2>;
> num-lanes = <2>;
>+ pinctrl-names = "default";
> status = "okay";
>
> vpcie12v-supply = <&vcc12v_dcin>;
>--
>2.32.0

--
Florian Klink

2021-11-21 18:52:29

by Heiko Stuebner

Subject: Re: [PATCH] arm64: dts: rockchip: helios64: add variables for pcie completion

On Thu, 28 Oct 2021 19:53:19 -0500, Dennis Gilmore wrote:
> without ep-gpios defined u-boot does not initialise PCIe
> rockchip_pcie pcie@f8000000: failed to find ep-gpios property
>
> additionally set max-link-speed and pinctrl-names for completeness
>
> with this patch and the ones from Florian Klink applied to the dts
> file in u-boot sata drives show up in both u-boot and linux

Applied, thanks!

[1/1] arm64: dts: rockchip: helios64: add variables for pcie completion
commit: 755fff528b1b760c700dbf39928ff3dda825f748

Best regards,
--
Heiko Stuebner <[email protected]>