2021-11-03 06:46:14

by CGEL

Subject: [PATCH] RISC-V: KVM:Remove unneeded semicolon

From: Zhang Mingyu <[email protected]>

Eliminate the following coccinelle check warning:
arch/riscv/kvm/vcpu.c:167:2-3
arch/riscv/kvm/vcpu.c:204:2-3

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Zhang Mingyu <[email protected]>
---
arch/riscv/kvm/vcpu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/riscv/kvm/vcpu.c b/arch/riscv/kvm/vcpu.c
index e92ba3e5db8c..e3d3aed46184 100644
--- a/arch/riscv/kvm/vcpu.c
+++ b/arch/riscv/kvm/vcpu.c
@@ -164,7 +164,7 @@ static int kvm_riscv_vcpu_get_reg_config(struct kvm_vcpu *vcpu,
break;
default:
return -EINVAL;
- };
+ }

if (copy_to_user(uaddr, &reg_val, KVM_REG_SIZE(reg->id)))
return -EFAULT;
@@ -201,7 +201,7 @@ static int kvm_riscv_vcpu_set_reg_config(struct kvm_vcpu *vcpu,
break;
default:
return -EINVAL;
- };
+ }

return 0;
}
--
2.25.1

2021-11-16 14:28:24

by Anup Patel

Subject: Re: [PATCH] RISC-V: KVM:Remove unneeded semicolon

On Wed, Nov 3, 2021 at 12:15 PM <[email protected]> wrote:
>
> From: Zhang Mingyu <[email protected]>
>
> Eliminate the following coccinelle check warning:
> arch/riscv/kvm/vcpu.c:167:2-3
> arch/riscv/kvm/vcpu.c:204:2-3
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Zhang Mingyu <[email protected]>

Thanks but this is already fixed by following patch:
https://www.spinics.net/lists/kvm/msg257614.html

Regards,
Anup

> ---
> arch/riscv/kvm/vcpu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/kvm/vcpu.c b/arch/riscv/kvm/vcpu.c
> index e92ba3e5db8c..e3d3aed46184 100644
> --- a/arch/riscv/kvm/vcpu.c
> +++ b/arch/riscv/kvm/vcpu.c
> @@ -164,7 +164,7 @@ static int kvm_riscv_vcpu_get_reg_config(struct kvm_vcpu *vcpu,
> break;
> default:
> return -EINVAL;
> - };
> + }
>
> if (copy_to_user(uaddr, &reg_val, KVM_REG_SIZE(reg->id)))
> return -EFAULT;
> @@ -201,7 +201,7 @@ static int kvm_riscv_vcpu_set_reg_config(struct kvm_vcpu *vcpu,
> break;
> default:
> return -EINVAL;
> - };
> + }
>
> return 0;
> }
> --
> 2.25.1
>