2021-11-03 22:16:57

by Suzuki K Poulose

Subject: [PATCH] arm64: cpufeature: Export this_cpu_has_cap helper

From: Arnd Bergmann <[email protected]>

Export the this_cpu_has_cap() for use by modules. This is
used by TRBE driver. Without this patch, TRBE will fail
to build as a module :

ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined!

Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling")
Cc: Will Deacon <[email protected]>
Cc: Catalin Marinas <[email protected]>
Cc: Mathieu Poirier <[email protected]>
Cc: Anshuman Khandual <[email protected]>
Signed-off-by: Arnd Bergmann <[email protected]>
[ change to EXPORT_SYMBOL_GPL ]
Acked-by: Catalin Marinas <[email protected]>
Signed-off-by: Suzuki K Poulose <[email protected]>
---
arch/arm64/kernel/cpufeature.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
index f8a3067d10c6..82e68c69bb99 100644
--- a/arch/arm64/kernel/cpufeature.c
+++ b/arch/arm64/kernel/cpufeature.c
@@ -2839,6 +2839,7 @@ bool this_cpu_has_cap(unsigned int n)

return false;
}
+EXPORT_SYMBOL_GPL(this_cpu_has_cap);

/*
* This helper function is used in a narrow window when,
--
2.25.4

2021-11-04 16:55:15

by Mathieu Poirier

Subject: Re: [PATCH] arm64: cpufeature: Export this_cpu_has_cap helper

On Wed, Nov 03, 2021 at 10:12:56PM +0000, Suzuki K Poulose wrote:
> From: Arnd Bergmann <[email protected]>
>
> Export the this_cpu_has_cap() for use by modules. This is
> used by TRBE driver. Without this patch, TRBE will fail
> to build as a module :
>
> ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined!
>
> Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling")
> Cc: Will Deacon <[email protected]>
> Cc: Catalin Marinas <[email protected]>
> Cc: Mathieu Poirier <[email protected]>
> Cc: Anshuman Khandual <[email protected]>
> Signed-off-by: Arnd Bergmann <[email protected]>
> [ change to EXPORT_SYMBOL_GPL ]
> Acked-by: Catalin Marinas <[email protected]>
> Signed-off-by: Suzuki K Poulose <[email protected]>
> ---
> arch/arm64/kernel/cpufeature.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> index f8a3067d10c6..82e68c69bb99 100644
> --- a/arch/arm64/kernel/cpufeature.c
> +++ b/arch/arm64/kernel/cpufeature.c
> @@ -2839,6 +2839,7 @@ bool this_cpu_has_cap(unsigned int n)
>
> return false;
> }
> +EXPORT_SYMBOL_GPL(this_cpu_has_cap);
>

I have applied this patch.

Thanks
Mathieu

> /*
> * This helper function is used in a narrow window when,
> --
> 2.25.4
>