2021-11-04 14:40:58

by Nghia Le

Subject: [PATCH] ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()

The newinet value is initialized with inet_sk() in a block code to
handle sockets for the ETH_P_IP protocol. Along this code path,
newinet is never read. Thus, assignment to newinet is needless and
can be removed.

Signed-off-by: Nghia Le <[email protected]>
---
net/ipv6/tcp_ipv6.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index 2cc9b0e53ad1..551fce49841d 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -1263,7 +1263,6 @@ static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff *

inet_sk(newsk)->pinet6 = tcp_inet6_sk(newsk);

- newinet = inet_sk(newsk);
newnp = tcp_inet6_sk(newsk);
newtp = tcp_sk(newsk);

--
2.25.1

2021-11-04 19:27:16

by Eric Dumazet

Subject: Re: [PATCH] ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()

On 11/4/21 7:37 AM, Nghia Le wrote:
> The newinet value is initialized with inet_sk() in a block code to
> handle sockets for the ETH_P_IP protocol. Along this code path,
> newinet is never read. Thus, assignment to newinet is needless and
> can be removed.
>
> Signed-off-by: Nghia Le <[email protected]>
> ---
> net/ipv6/tcp_ipv6.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
> index 2cc9b0e53ad1..551fce49841d 100644
> --- a/net/ipv6/tcp_ipv6.c
> +++ b/net/ipv6/tcp_ipv6.c
> @@ -1263,7 +1263,6 @@ static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff *
>
> inet_sk(newsk)->pinet6 = tcp_inet6_sk(newsk);
>
> - newinet = inet_sk(newsk);
> newnp = tcp_inet6_sk(newsk);
> newtp = tcp_sk(newsk);
>
>

Reviewed-by: Eric Dumazet <[email protected]>

2021-11-06 10:18:03

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

On Thu, 4 Nov 2021 21:37:40 +0700 you wrote:
> The newinet value is initialized with inet_sk() in a block code to
> handle sockets for the ETH_P_IP protocol. Along this code path,
> newinet is never read. Thus, assignment to newinet is needless and
> can be removed.
>
> Signed-off-by: Nghia Le <[email protected]>
>
> [...]

Here is the summary with links:
- ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()
https://git.kernel.org/netdev/net/c/70bf363d7adb

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

2021-11-06 15:27:56

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()

Hello:

This patch was applied to bpf/bpf.git (master)
by Jakub Kicinski <[email protected]>:

On Thu, 4 Nov 2021 21:37:40 +0700 you wrote:
> The newinet value is initialized with inet_sk() in a block code to
> handle sockets for the ETH_P_IP protocol. Along this code path,
> newinet is never read. Thus, assignment to newinet is needless and
> can be removed.
>
> Signed-off-by: Nghia Le <[email protected]>
>
> [...]

Here is the summary with links:
- ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()
https://git.kernel.org/bpf/bpf/c/70bf363d7adb

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html