Replace builtin_platform_driver_probe with module_platform_driver_probe
because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).
Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
Cc: Fabio Estevam <[email protected]>
Cc: Stephen Boyd <[email protected]>
Signed-off-by: Miles Chen <[email protected]>
---
Change since v2:
use correct Fixes tag
Change since v1:
Add Fixes tags
---
drivers/clk/imx/clk-imx8qxp-lpcg.c | 2 +-
drivers/clk/imx/clk-imx8qxp.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c
index d3e905cf867d..b23758083ce5 100644
--- a/drivers/clk/imx/clk-imx8qxp-lpcg.c
+++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c
@@ -370,7 +370,7 @@ static struct platform_driver imx8qxp_lpcg_clk_driver = {
.probe = imx8qxp_lpcg_clk_probe,
};
-builtin_platform_driver(imx8qxp_lpcg_clk_driver);
+module_platform_driver(imx8qxp_lpcg_clk_driver);
MODULE_AUTHOR("Aisheng Dong <[email protected]>");
MODULE_DESCRIPTION("NXP i.MX8QXP LPCG clock driver");
diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c
index c53a688d8ccc..40a2efb1329b 100644
--- a/drivers/clk/imx/clk-imx8qxp.c
+++ b/drivers/clk/imx/clk-imx8qxp.c
@@ -308,7 +308,7 @@ static struct platform_driver imx8qxp_clk_driver = {
},
.probe = imx8qxp_clk_probe,
};
-builtin_platform_driver(imx8qxp_clk_driver);
+module_platform_driver(imx8qxp_clk_driver);
MODULE_AUTHOR("Aisheng Dong <[email protected]>");
MODULE_DESCRIPTION("NXP i.MX8QXP clock driver");
--
2.18.0
Hi Miles,
On Sat, Sep 4, 2021 at 8:54 PM Miles Chen <[email protected]> wrote:
>
> Replace builtin_platform_driver_probe with module_platform_driver_probe
> because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).
>
> Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
> Cc: Fabio Estevam <[email protected]>
> Cc: Stephen Boyd <[email protected]>
> Signed-off-by: Miles Chen <[email protected]>
Reviewed-by: Fabio Estevam <[email protected]>
Quoting Miles Chen (2021-09-04 16:54:18)
> Replace builtin_platform_driver_probe with module_platform_driver_probe
> because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).
>
> Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
> Cc: Fabio Estevam <[email protected]>
> Cc: Stephen Boyd <[email protected]>
> Signed-off-by: Miles Chen <[email protected]>
>
> ---
Reviewed-by: Stephen Boyd <[email protected]>
From: Miles Chen <[email protected]>
Hi Stephen,
>> Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
>> Cc: Fabio Estevam <[email protected]>
>> Cc: Stephen Boyd <[email protected]>
>> Signed-off-by: Miles Chen <[email protected]>
> Reviewed-by: Stephen Boyd <[email protected]>
Thanks for doing the review, I cannot find this patch in clk-imx tree,
Would you pick this patch, please?
Miles
On 21-11-05 13:59:32, [email protected] wrote:
> From: Miles Chen <[email protected]>
>
> Hi Stephen,
>
> >> Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
> >> Cc: Fabio Estevam <[email protected]>
> >> Cc: Stephen Boyd <[email protected]>
> >> Signed-off-by: Miles Chen <[email protected]>
>
> > Reviewed-by: Stephen Boyd <[email protected]>
>
> Thanks for doing the review, I cannot find this patch in clk-imx tree,
> Would you pick this patch, please?
Sorry for the delay.
Fixes are usually picked up directly by Stephen,
therefore they're not going through clk-imx tree.
Stephen, can you pick this one up please?
>
> Miles
Quoting Abel Vesa (2021-11-20 12:37:24)
> On 21-11-05 13:59:32, [email protected] wrote:
> > From: Miles Chen <[email protected]>
> >
> > Hi Stephen,
> >
> > >> Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
> > >> Cc: Fabio Estevam <[email protected]>
> > >> Cc: Stephen Boyd <[email protected]>
> > >> Signed-off-by: Miles Chen <[email protected]>
> >
> > > Reviewed-by: Stephen Boyd <[email protected]>
> >
> > Thanks for doing the review, I cannot find this patch in clk-imx tree,
> > Would you pick this patch, please?
>
> Sorry for the delay.
>
> Fixes are usually picked up directly by Stephen,
> therefore they're not going through clk-imx tree.
>
> Stephen, can you pick this one up please?
>
It doesn't look like a very critical fix but ok. I suppose someone could
try to use =m for these files?
On 21-12-02 17:57:13, Stephen Boyd wrote:
> Quoting Abel Vesa (2021-11-20 12:37:24)
> > On 21-11-05 13:59:32, [email protected] wrote:
> > > From: Miles Chen <[email protected]>
> > >
> > > Hi Stephen,
> > >
> > > >> Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
> > > >> Cc: Fabio Estevam <[email protected]>
> > > >> Cc: Stephen Boyd <[email protected]>
> > > >> Signed-off-by: Miles Chen <[email protected]>
> > >
> > > > Reviewed-by: Stephen Boyd <[email protected]>
> > >
> > > Thanks for doing the review, I cannot find this patch in clk-imx tree,
> > > Would you pick this patch, please?
> >
> > Sorry for the delay.
> >
> > Fixes are usually picked up directly by Stephen,
> > therefore they're not going through clk-imx tree.
> >
> > Stephen, can you pick this one up please?
> >
>
> It doesn't look like a very critical fix but ok. I suppose someone could
> try to use =m for these files?
Yes. I think this is for GKI.