2021-11-05 17:23:24

by Anders Roxell

Subject: [PATCH] selftests: net: tls: remove unused variable and code

When building selftests/net with clang, the compiler warn about the
function abs() see below:

tls.c:657:15: warning: variable 'len_compared' set but not used [-Wunused-but-set-variable]
unsigned int len_compared = 0;
^

Rework to remove the unused variable and the for-loop where the variable
'len_compared' was assinged.

Signed-off-by: Anders Roxell <[email protected]>
---
tools/testing/selftests/net/tls.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/net/tls.c
index d3047e251fe9..e61fc4c32ba2 100644
--- a/tools/testing/selftests/net/tls.c
+++ b/tools/testing/selftests/net/tls.c
@@ -654,7 +654,6 @@ TEST_F(tls, recvmsg_single_max)
TEST_F(tls, recvmsg_multiple)
{
unsigned int msg_iovlen = 1024;
- unsigned int len_compared = 0;
struct iovec vec[1024];
char *iov_base[1024];
unsigned int iov_len = 16;
@@ -675,8 +674,6 @@ TEST_F(tls, recvmsg_multiple)
hdr.msg_iovlen = msg_iovlen;
hdr.msg_iov = vec;
EXPECT_NE(recvmsg(self->cfd, &hdr, 0), -1);
- for (i = 0; i < msg_iovlen; i++)
- len_compared += iov_len;

for (i = 0; i < msg_iovlen; i++)
free(iov_base[i]);
--
2.33.0

2021-11-05 23:59:30

by Nick Desaulniers

Subject: Re: [PATCH] selftests: net: tls: remove unused variable and code

On Fri, Nov 5, 2021 at 9:45 AM Anders Roxell <[email protected]> wrote:
>
> When building selftests/net with clang, the compiler warn about the
> function abs() see below:
>
> tls.c:657:15: warning: variable 'len_compared' set but not used [-Wunused-but-set-variable]
> unsigned int len_compared = 0;
> ^
>
> Rework to remove the unused variable and the for-loop where the variable
> 'len_compared' was assinged.
>
> Signed-off-by: Anders Roxell <[email protected]>

Thanks for the patch. Hard to say what the original intent was here.

Fixes: 7f657d5bf507 ("selftests: tls: add selftests for TLS sockets")
Reviewed-by: Nick Desaulniers <[email protected]>

> ---
> tools/testing/selftests/net/tls.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/net/tls.c
> index d3047e251fe9..e61fc4c32ba2 100644
> --- a/tools/testing/selftests/net/tls.c
> +++ b/tools/testing/selftests/net/tls.c
> @@ -654,7 +654,6 @@ TEST_F(tls, recvmsg_single_max)
> TEST_F(tls, recvmsg_multiple)
> {
> unsigned int msg_iovlen = 1024;
> - unsigned int len_compared = 0;
> struct iovec vec[1024];
> char *iov_base[1024];
> unsigned int iov_len = 16;
> @@ -675,8 +674,6 @@ TEST_F(tls, recvmsg_multiple)
> hdr.msg_iovlen = msg_iovlen;
> hdr.msg_iov = vec;
> EXPECT_NE(recvmsg(self->cfd, &hdr, 0), -1);
> - for (i = 0; i < msg_iovlen; i++)
> - len_compared += iov_len;
>
> for (i = 0; i < msg_iovlen; i++)
> free(iov_base[i]);
> --
> 2.33.0
>


--
Thanks,
~Nick Desaulniers

2021-11-08 00:50:48

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] selftests: net: tls: remove unused variable and code

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

On Fri, 5 Nov 2021 17:45:11 +0100 you wrote:
> When building selftests/net with clang, the compiler warn about the
> function abs() see below:
>
> tls.c:657:15: warning: variable 'len_compared' set but not used [-Wunused-but-set-variable]
> unsigned int len_compared = 0;
> ^
>
> [...]

Here is the summary with links:
- selftests: net: tls: remove unused variable and code
https://git.kernel.org/netdev/net/c/62b12ab5dff0

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html