2021-11-08 00:50:20

by Ondřej Jirman

Subject: Re: [PATCH 06/15] usb: typec: fusb302: Fix masking of comparator and bc_lvl interrupts

Hi,

On Sun, Nov 07, 2021 at 07:54:33PM +0100, megous hlavni wrote:
> The masks are swapped (interrupts are enabled when the mask is 0).

Please ignore the 06/15 in the subject. This is just a single patch
from my local series and I forgot to edit the subject.

kind regards,
o.

> This caused inability of the driver to recognize cable unplug events
> in host mode (where only comparator interrupt is generated, and VBUS
> interrupt is not).
>
> Signed-off-by: Ondrej Jirman <[email protected]>
> ---
> drivers/usb/typec/tcpm/fusb302.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 7a2a17866a823..72f9001b07921 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -669,25 +669,27 @@ static int tcpm_set_cc(struct tcpc_dev *dev, enum typec_cc_status cc)
> ret = fusb302_i2c_mask_write(chip, FUSB_REG_MASK,
> FUSB_REG_MASK_BC_LVL |
> FUSB_REG_MASK_COMP_CHNG,
> - FUSB_REG_MASK_COMP_CHNG);
> + FUSB_REG_MASK_BC_LVL);
> if (ret < 0) {
> fusb302_log(chip, "cannot set SRC interrupt, ret=%d",
> ret);
> goto done;
> }
> chip->intr_comp_chng = true;
> + chip->intr_bc_lvl = false;
> break;
> case TYPEC_CC_RD:
> ret = fusb302_i2c_mask_write(chip, FUSB_REG_MASK,
> FUSB_REG_MASK_BC_LVL |
> FUSB_REG_MASK_COMP_CHNG,
> - FUSB_REG_MASK_BC_LVL);
> + FUSB_REG_MASK_COMP_CHNG);
> if (ret < 0) {
> fusb302_log(chip, "cannot set SRC interrupt, ret=%d",
> ret);
> goto done;
> }
> chip->intr_bc_lvl = true;
> + chip->intr_comp_chng = false;
> break;
> default:
> break;
> --
> 2.33.1
>

2021-11-08 11:43:29

by Greg Kroah-Hartman

Subject: Re: [PATCH 06/15] usb: typec: fusb302: Fix masking of comparator and bc_lvl interrupts

On Sun, Nov 07, 2021 at 07:57:24PM +0100, Ondřej Jirman wrote:
> Hi,
>
> On Sun, Nov 07, 2021 at 07:54:33PM +0100, megous hlavni wrote:
> > The masks are swapped (interrupts are enabled when the mask is 0).
>
> Please ignore the 06/15 in the subject. This is just a single patch
> from my local series and I forgot to edit the subject.

But I see 2 patches sent in this series?

Can you just fix this up and resend them correctly?

thanks,

greg k-h