2021-11-08 00:50:15

by Ondřej Jirman

Subject: phy: rockchip-inno-usb2: Don't print useless error

The interrupt is optional, make the dmesg not complain about it
missing.

Signed-off-by: Ondrej Jirman <[email protected]>
---
drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
index 428c2313a9cb2..27820bee04eae 100644
--- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
+++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
@@ -1180,7 +1180,7 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
phy_cfgs = match->data;
rphy->chg_state = USB_CHG_STATE_UNDEFINED;
rphy->chg_type = POWER_SUPPLY_TYPE_UNKNOWN;
- rphy->irq = platform_get_irq(pdev, 0);
+ rphy->irq = platform_get_irq_optional(pdev, 0);
platform_set_drvdata(pdev, rphy);

ret = rockchip_usb2phy_extcon_register(rphy);
--
2.33.1

2021-11-08 01:52:38

by Ondřej Jirman

Subject: Re: phy: rockchip-inno-usb2: Don't print useless error

On Sun, Nov 07, 2021 at 07:58:35PM +0100, megous hlavni wrote:
> The interrupt is optional, make the dmesg not complain about it
> missing.

Ooops. Sorry, this applies only on top of Peter Geis's

"phy: phy-rockchip-inno-usb2: support muxed interrupts"

which is not mainline yet. Please ignore.

kind regards,
o.

> Signed-off-by: Ondrej Jirman <[email protected]>
> ---
> drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> index 428c2313a9cb2..27820bee04eae 100644
> --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> @@ -1180,7 +1180,7 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
> phy_cfgs = match->data;
> rphy->chg_state = USB_CHG_STATE_UNDEFINED;
> rphy->chg_type = POWER_SUPPLY_TYPE_UNKNOWN;
> - rphy->irq = platform_get_irq(pdev, 0);
> + rphy->irq = platform_get_irq_optional(pdev, 0);
> platform_set_drvdata(pdev, rphy);
>
> ret = rockchip_usb2phy_extcon_register(rphy);
> --
> 2.33.1
>