2021-11-08 07:31:59

by Yang Li

Subject: [PATCH -next] gpio: virtio: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/gpio/gpio-virtio.c:437:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/gpio/gpio-virtio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-virtio.c b/drivers/gpio/gpio-virtio.c
index aeec4bf..84f96b7 100644
--- a/drivers/gpio/gpio-virtio.c
+++ b/drivers/gpio/gpio-virtio.c
@@ -434,7 +434,7 @@ static void virtio_gpio_event_vq(struct virtqueue *vq)
ret = generic_handle_domain_irq(vgpio->gc.irq.domain, gpio);
if (ret)
dev_err(dev, "failed to handle interrupt: %d\n", ret);
- };
+ }
}

static void virtio_gpio_request_vq(struct virtqueue *vq)
--
1.8.3.1

2021-11-08 07:35:46

by Viresh Kumar

Subject: Re: [PATCH -next] gpio: virtio: remove unneeded semicolon

On 08-11-21, 12:03, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/gpio/gpio-virtio.c:437:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/gpio/gpio-virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-virtio.c b/drivers/gpio/gpio-virtio.c
> index aeec4bf..84f96b7 100644
> --- a/drivers/gpio/gpio-virtio.c
> +++ b/drivers/gpio/gpio-virtio.c
> @@ -434,7 +434,7 @@ static void virtio_gpio_event_vq(struct virtqueue *vq)
> ret = generic_handle_domain_irq(vgpio->gc.irq.domain, gpio);
> if (ret)
> dev_err(dev, "failed to handle interrupt: %d\n", ret);
> - };
> + }
> }
>
> static void virtio_gpio_request_vq(struct virtqueue *vq)

Acked-by: Viresh Kumar <[email protected]>

--
viresh

2021-11-15 13:26:27

by Bartosz Golaszewski

Subject: Re: [PATCH -next] gpio: virtio: remove unneeded semicolon

On Mon, Nov 8, 2021 at 5:04 AM Yang Li <[email protected]> wrote:
>
> Eliminate the following coccicheck warning:
> ./drivers/gpio/gpio-virtio.c:437:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/gpio/gpio-virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-virtio.c b/drivers/gpio/gpio-virtio.c
> index aeec4bf..84f96b7 100644
> --- a/drivers/gpio/gpio-virtio.c
> +++ b/drivers/gpio/gpio-virtio.c
> @@ -434,7 +434,7 @@ static void virtio_gpio_event_vq(struct virtqueue *vq)
> ret = generic_handle_domain_irq(vgpio->gc.irq.domain, gpio);
> if (ret)
> dev_err(dev, "failed to handle interrupt: %d\n", ret);
> - };
> + }
> }
>
> static void virtio_gpio_request_vq(struct virtqueue *vq)
> --
> 1.8.3.1
>

Queued for fixes, thanks!

Bart