2021-11-09 15:48:56

by Guo Zhengkui

Subject: [PATCH] ACPI: processor idle: fix swap.cocci warning

Fix following coccicheck warning:
./drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c:914:40-41:
WARNING opportunity for swap().

swap() was used instead of the tmp variable to swap values.

Signed-off-by: Guo Zhengkui <[email protected]>
---
drivers/acpi/processor_idle.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index 76ef1bcc8848..4b906bb527e8 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -20,6 +20,7 @@
#include <linux/tick.h>
#include <linux/cpuidle.h>
#include <linux/cpu.h>
+#include <linux/minmax.h>
#include <acpi/processor.h>

/*
@@ -400,13 +401,10 @@ static int acpi_cst_latency_cmp(const void *a, const void *b)
static void acpi_cst_latency_swap(void *a, void *b, int n)
{
struct acpi_processor_cx *x = a, *y = b;
- u32 tmp;

if (!(x->valid && y->valid))
return;
- tmp = x->latency;
- x->latency = y->latency;
- y->latency = tmp;
+ swap(x->latency, y->latency);
}

static int acpi_processor_power_verify(struct acpi_processor *pr)
--
2.20.1

2021-11-24 16:48:45

by Rafael J. Wysocki

Subject: Re: [PATCH] ACPI: processor idle: fix swap.cocci warning

On Tue, Nov 9, 2021 at 8:51 AM Guo Zhengkui <[email protected]> wrote:
>
> Fix following coccicheck warning:
> ./drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c:914:40-41:
> WARNING opportunity for swap().
>
> swap() was used instead of the tmp variable to swap values.
>
> Signed-off-by: Guo Zhengkui <[email protected]>
> ---
> drivers/acpi/processor_idle.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index 76ef1bcc8848..4b906bb527e8 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -20,6 +20,7 @@
> #include <linux/tick.h>
> #include <linux/cpuidle.h>
> #include <linux/cpu.h>
> +#include <linux/minmax.h>
> #include <acpi/processor.h>
>
> /*
> @@ -400,13 +401,10 @@ static int acpi_cst_latency_cmp(const void *a, const void *b)
> static void acpi_cst_latency_swap(void *a, void *b, int n)
> {
> struct acpi_processor_cx *x = a, *y = b;
> - u32 tmp;
>
> if (!(x->valid && y->valid))
> return;
> - tmp = x->latency;
> - x->latency = y->latency;
> - y->latency = tmp;
> + swap(x->latency, y->latency);
> }
>
> static int acpi_processor_power_verify(struct acpi_processor *pr)
> --

Applied as 5.17 material with edited subject and changelog, thanks!