2021-11-10 00:18:52

by Guilherme G. Piccoli

Subject: [PATCH 1/3] docs: sysctl/kernel: Add missing bit to panic_print

Commit de6da1e8bcf0 ("panic: add an option to replay all the printk message in buffer")
added a new bit to the sysctl/kernel parameter "panic_print", but the
documentation was added only in kernel-parameters.txt, not in the sysctl guide.

Fix it here by adding bit 5 to sysctl admin-guide documentation.

Cc: Feng Tang <[email protected]>
Fixes: de6da1e8bcf0 ("panic: add an option to replay all the printk message in buffer")
Signed-off-by: Guilherme G. Piccoli <[email protected]>
---
Documentation/admin-guide/sysctl/kernel.rst | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
index 426162009ce9..70b7df9b081a 100644
--- a/Documentation/admin-guide/sysctl/kernel.rst
+++ b/Documentation/admin-guide/sysctl/kernel.rst
@@ -795,6 +795,7 @@ bit 1 print system memory info
bit 2 print timer info
bit 3 print locks info if ``CONFIG_LOCKDEP`` is on
bit 4 print ftrace buffer
+bit 5: print all printk messages in buffer
===== ============================================

So for example to print tasks and memory info on panic, user can::
--
2.33.1

2021-11-30 05:10:12

by Feng Tang

Subject: Re: [PATCH 1/3] docs: sysctl/kernel: Add missing bit to panic_print

On Tue, Nov 09, 2021 at 05:28:46PM -0300, Guilherme G. Piccoli wrote:
> Commit de6da1e8bcf0 ("panic: add an option to replay all the printk message in buffer")
> added a new bit to the sysctl/kernel parameter "panic_print", but the
> documentation was added only in kernel-parameters.txt, not in the sysctl guide.
>
> Fix it here by adding bit 5 to sysctl admin-guide documentation.

Thanks for the fix!

Reviewed-by: Feng Tang <[email protected]>

- Feng

> Cc: Feng Tang <[email protected]>
> Fixes: de6da1e8bcf0 ("panic: add an option to replay all the printk message in buffer")
> Signed-off-by: Guilherme G. Piccoli <[email protected]>
> ---
> Documentation/admin-guide/sysctl/kernel.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
> index 426162009ce9..70b7df9b081a 100644
> --- a/Documentation/admin-guide/sysctl/kernel.rst
> +++ b/Documentation/admin-guide/sysctl/kernel.rst
> @@ -795,6 +795,7 @@ bit 1 print system memory info
> bit 2 print timer info
> bit 3 print locks info if ``CONFIG_LOCKDEP`` is on
> bit 4 print ftrace buffer
> +bit 5: print all printk messages in buffer
> ===== ============================================
>
> So for example to print tasks and memory info on panic, user can::
> --
> 2.33.1