2021-11-10 04:09:57

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the hid tree

Hi all,

After merging the hid tree, today's linux-next build (htmldocs) produced
this warning:

include/linux/mod_devicetable.h:909: warning: Function parameter or member 'guid' not described in 'ishtp_device_id'

Introduced by commit

fa443bc3c1e4 ("HID: intel-ish-hid: add support for MODULE_DEVICE_TABLE()")

I also notice that there is a @context description, but no field.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-11-10 08:23:21

by Jiri Kosina

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the hid tree

On Wed, 10 Nov 2021, Stephen Rothwell wrote:

> Hi all,
>
> After merging the hid tree, today's linux-next build (htmldocs) produced
> this warning:
>
> include/linux/mod_devicetable.h:909: warning: Function parameter or member 'guid' not described in 'ishtp_device_id'
>
> Introduced by commit
>
> fa443bc3c1e4 ("HID: intel-ish-hid: add support for MODULE_DEVICE_TABLE()")
>
> I also notice that there is a @context description, but no field.

Thanks for spotting it. The kerneldoc is clearly wrong there both on the
'guid' member name, and also the description (mind the '36 char' part,
where it should have been '16 char' instead).

Thomas, could you please send me a fixup patch for that?

Thanks,

--
Jiri Kosina
SUSE Labs

2021-11-10 12:19:41

by Thomas Weißschuh

[permalink] [raw]
Subject: [PATCH] mod_devicetable: fix kdocs for ishtp_device_id

The kdocs were copied from another device_id struct and not adapted.

Fixes: fa443bc3c1e4 ("HID: intel-ish-hid: add support for MODULE_DEVICE_TABLE()")
Signed-off-by: Thomas Weißschuh <[email protected]>
---
include/linux/mod_devicetable.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
index befbf53c4b7c..c70abe7aaef2 100644
--- a/include/linux/mod_devicetable.h
+++ b/include/linux/mod_devicetable.h
@@ -901,8 +901,7 @@ struct dfl_device_id {

/**
* struct ishtp_device_id - ISHTP device identifier
- * @guid_string: 36 char string of the form fa50ff2b-f2e8-45de-83fa-65417f2f49ba
- * @context: pointer to driver specific data
+ * @guid: GUID of the device.
*/
struct ishtp_device_id {
guid_t guid;

base-commit: 7fb0413baa7f8a04caef0c504df9af7e0623d296
--
2.33.1

2021-11-10 12:23:02

by Jiri Kosina

[permalink] [raw]
Subject: Re: [PATCH] mod_devicetable: fix kdocs for ishtp_device_id

On Wed, 10 Nov 2021, Thomas Weißschuh wrote:

> The kdocs were copied from another device_id struct and not adapted.
>
> Fixes: fa443bc3c1e4 ("HID: intel-ish-hid: add support for MODULE_DEVICE_TABLE()")
> Signed-off-by: Thomas Weißschuh <[email protected]>

I've added

Reported-by: Stephen Rothwell <[email protected]>

and applied, thanks.

--
Jiri Kosina
SUSE Labs