2021-11-10 19:36:44

by Colin Ian King

[permalink] [raw]

Subject: [PATCH] drm/v3d: pass null pointers using NULL

---

There are a couple of calls that are passing null pointers as
integer zeros rather than NULL. Fix this by using NULL instead.

Fixes: 07c2a41658c4 ("drm/v3d: alloc and init job in one shot")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/gpu/drm/v3d/v3d_gem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
index e47ae40a865a..c7ed2e1cbab6 100644
--- a/drivers/gpu/drm/v3d/v3d_gem.c
+++ b/drivers/gpu/drm/v3d/v3d_gem.c
@@ -774,7 +774,7 @@ v3d_submit_cl_ioctl(struct drm_device *dev, void *data,

if (args->flags & DRM_V3D_SUBMIT_CL_FLUSH_CACHE) {
ret = v3d_job_init(v3d, file_priv, (void *)&clean_job, sizeof(*clean_job),
- v3d_job_free, 0, 0, V3D_CACHE_CLEAN);
+ v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
if (ret)
goto fail;

@@ -1007,7 +1007,7 @@ v3d_submit_csd_ioctl(struct drm_device *dev, void *data,
goto fail;

ret = v3d_job_init(v3d, file_priv, (void *)&clean_job, sizeof(*clean_job),
- v3d_job_free, 0, 0, V3D_CACHE_CLEAN);
+ v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
if (ret)
goto fail;

--
2.32.0

2021-11-11 18:47:08

by Melissa Wen

[permalink] [raw]

Subject: Re: [PATCH] drm/v3d: pass null pointers using NULL

---

On 11/10, Colin Ian King wrote:
> There are a couple of calls that are passing null pointers as
> integer zeros rather than NULL. Fix this by using NULL instead.
>
> Fixes: 07c2a41658c4 ("drm/v3d: alloc and init job in one shot")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/gpu/drm/v3d/v3d_gem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
> index e47ae40a865a..c7ed2e1cbab6 100644
> --- a/drivers/gpu/drm/v3d/v3d_gem.c
> +++ b/drivers/gpu/drm/v3d/v3d_gem.c
> @@ -774,7 +774,7 @@ v3d_submit_cl_ioctl(struct drm_device *dev, void *data,
>
> if (args->flags & DRM_V3D_SUBMIT_CL_FLUSH_CACHE) {
> ret = v3d_job_init(v3d, file_priv, (void *)&clean_job, sizeof(*clean_job),
> - v3d_job_free, 0, 0, V3D_CACHE_CLEAN);
> + v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
> if (ret)
> goto fail;
>
> @@ -1007,7 +1007,7 @@ v3d_submit_csd_ioctl(struct drm_device *dev, void *data,
> goto fail;
>
> ret = v3d_job_init(v3d, file_priv, (void *)&clean_job, sizeof(*clean_job),
> - v3d_job_free, 0, 0, V3D_CACHE_CLEAN);
> + v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
> if (ret)
> goto fail;

Hi Colin,

This fix has been already done:
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=75ad021f21927311b8d454939eb248a50df92525

Thanks, anyway.

Melissa
>
> --
> 2.32.0
>

---

Attachments:

(No filename) (1.39 kB)
signature.asc (833.00 B)
Download all attachments