2021-11-12 03:03:31

by Yihao Han

[permalink] [raw]
Subject: [PATCH] libtraceevent: use swap() to make code cleaner

Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.

Signed-off-by: Yihao Han <[email protected]>
---
tools/lib/traceevent/event-parse.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index fe58843d047c..71bddcc9ff3b 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -2081,14 +2081,10 @@ process_op(struct tep_event *event, struct tep_print_arg *arg, char **tok)

if (right->type == TEP_PRINT_OP &&
get_op_prio(arg->op.op) < get_op_prio(right->op.op)) {
- struct tep_print_arg tmp;
-
/* rotate ops according to the priority */
arg->op.right = right->op.left;

- tmp = *arg;
- *arg = *right;
- *right = tmp;
+ swap(*arg, *right);

arg->op.left = right;
} else {
--
2.17.1