2021-11-12 09:17:52

by Adamos Ttofari

Subject: [PATCH] cpufreq: intel_pstate: Add Ice Lake server to out-of-band IDs

Commit fbdc21e9b038 ("cpufreq: intel_pstate: Add Icelake servers support in
no-HWP mode") enabled the use of Intel P-State driver for Ice Lake servers.
But it doesn't cover the case when OS can't control P-States.

Therefore, for Ice Lake server, if MSR_MISC_PWR_MGMT bits 8 or 18 are
enabled, then the Intel P-State driver should exit as OS can't control
P-States.

Fixes: fbdc21e9b038 ("cpufreq: intel_pstate: Add Icelake servers support in no-HWP mode")

Signed-off-by: Adamos Ttofari <[email protected]>
Cc: Hendrik Borghorst <[email protected]>
Cc: David Woodhouse <[email protected]>
---
drivers/cpufreq/intel_pstate.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 815df3daae9d..1088ff350159 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -2353,6 +2353,7 @@ static const struct x86_cpu_id intel_pstate_cpu_oob_ids[] __initconst = {
X86_MATCH(BROADWELL_D, core_funcs),
X86_MATCH(BROADWELL_X, core_funcs),
X86_MATCH(SKYLAKE_X, core_funcs),
+ X86_MATCH(ICELAKE_X, core_funcs),
{}
};

--
2.32.0




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879

2021-11-17 19:12:27

by Rafael J. Wysocki

Subject: Re: [PATCH] cpufreq: intel_pstate: Add Ice Lake server to out-of-band IDs

On Fri, Nov 12, 2021 at 10:17 AM Adamos Ttofari <[email protected]> wrote:
>
> Commit fbdc21e9b038 ("cpufreq: intel_pstate: Add Icelake servers support in
> no-HWP mode") enabled the use of Intel P-State driver for Ice Lake servers.
> But it doesn't cover the case when OS can't control P-States.
>
> Therefore, for Ice Lake server, if MSR_MISC_PWR_MGMT bits 8 or 18 are
> enabled, then the Intel P-State driver should exit as OS can't control
> P-States.
>
> Fixes: fbdc21e9b038 ("cpufreq: intel_pstate: Add Icelake servers support in no-HWP mode")
>
> Signed-off-by: Adamos Ttofari <[email protected]>
> Cc: Hendrik Borghorst <[email protected]>
> Cc: David Woodhouse <[email protected]>
> ---
> drivers/cpufreq/intel_pstate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 815df3daae9d..1088ff350159 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2353,6 +2353,7 @@ static const struct x86_cpu_id intel_pstate_cpu_oob_ids[] __initconst = {
> X86_MATCH(BROADWELL_D, core_funcs),
> X86_MATCH(BROADWELL_X, core_funcs),
> X86_MATCH(SKYLAKE_X, core_funcs),
> + X86_MATCH(ICELAKE_X, core_funcs),
> {}
> };
>
> --

Applied as 5.16-rc material, thanks!