2021-11-15 03:25:10

by Yihao Han

[permalink] [raw]
Subject: [PATCH] leds: tca6507: use swap() to make code cleaner

Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.

Signed-off-by: Yihao Han <[email protected]>
---
drivers/leds/leds-tca6507.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
index 225b765830bd..de8eed9b667d 100644
--- a/drivers/leds/leds-tca6507.c
+++ b/drivers/leds/leds-tca6507.c
@@ -242,9 +242,7 @@ static int choose_times(int msec, int *c1p, int *c2p)
if (diff < 65536) {
int actual;
if (msec & 1) {
- c1 = *c2p;
- *c2p = *c1p;
- *c1p = c1;
+ swap(*c2p, *c1p);
}
actual = time_codes[*c1p] + time_codes[*c2p];
if (*c1p < *c2p)
--
2.17.1



2021-11-15 14:09:01

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH] leds: tca6507: use swap() to make code cleaner

On Sun 2021-11-14 19:24:28, Yihao Han wrote:
> Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> opencoding it.
>
> Signed-off-by: Yihao Han <[email protected]>

Thanks, applied.
Pavel


--
http://www.livejournal.com/~pavelmachek


Attachments:
(No filename) (268.00 B)
signature.asc (195.00 B)
Download all attachments